From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14F62C2D0C9 for ; Sat, 14 Dec 2019 07:51:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E239A2073D for ; Sat, 14 Dec 2019 07:51:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="B5c9YO+Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726050AbfLNHvr (ORCPT ); Sat, 14 Dec 2019 02:51:47 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:59478 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbfLNHvr (ORCPT ); Sat, 14 Dec 2019 02:51:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=WAFCLYGV8jNiyKKmUCzFAPrQcuYc31iQJNkSj8zCW2U=; b=B5c9YO+Zy+RTcHNTGcvBCk1qk GjVq+ncgLD993LzLfsfCf/y7RSVYl9Td1NFBf1cjuiDygqQxyjOh1gib/mfHTcOIdOXeCQLNWVaf4 KhiPDsNMvPFS6vZQ/LXrHns/U1y409D57uC5ln0bkcVYe4TpvKue81y717hA7qeBvQ0QgkNcBHvOz zu9Olqm38uoDDstbP2V9/UWClfAHYqvvZfs5KnsnXVnNB7WbR02gh/bPDkHRhipQ2dtZ2eRRaCfE7 QAOuU/1iYu18+1REcJIMAeYk32YcJ1orR1Gy5ARefQV4LVWf7PRxR7zMzNbGMXkI6iA4XPRnek2/5 Lz3/ktefQ==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:41150) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ig2D5-0001dV-DI; Sat, 14 Dec 2019 07:51:34 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1ig2D1-0000GN-Dl; Sat, 14 Dec 2019 07:51:27 +0000 Date: Sat, 14 Dec 2019 07:51:27 +0000 From: Russell King - ARM Linux admin To: Jakub Kicinski Cc: "David S. Miller" , Antoine Tenart , Willy Tarreau , Andrew Lunn , Thomas Bogendoerfer , maxime.chevallier@bootlin.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: marvell: mvpp2: phylink requires the link interrupt Message-ID: <20191214075127.GX25745@shell.armlinux.org.uk> References: <20191213163403.2a054262@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191213163403.2a054262@cakuba.netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Dec 13, 2019 at 04:34:03PM -0800, Jakub Kicinski wrote: > On Tue, 10 Dec 2019 22:33:05 +0000, Russell King wrote: > > phylink requires the MAC to report when its link status changes when > > operating in inband modes. Failure to report link status changes > > means that phylink has no idea when the link events happen, which > > results in either the network interface's carrier remaining up or > > remaining permanently down. > > > > For example, with a fiber module, if the interface is brought up and > > link is initially established, taking the link down at the far end > > will cut the optical power. The SFP module's LOS asserts, we > > deactivate the link, and the network interface reports no carrier. > > > > When the far end is brought back up, the SFP module's LOS deasserts, > > but the MAC may be slower to establish link. If this happens (which > > in my tests is a certainty) then phylink never hears that the MAC > > has established link with the far end, and the network interface is > > stuck reporting no carrier. This means the interface is > > non-functional. > > > > Avoiding the link interrupt when we have phylink is basically not > > an option, so remove the !port->phylink from the test. > > > > Tested-by: Sven Auhagen > > Tested-by: Antoine Tenart > > Signed-off-by: Russell King > > Fixes: 4bb043262878 ("net: mvpp2: phylink support") ? > > Seems like you maybe didn't want this backported to stable hence > no fixes tag? Correct, because backporting just this patch will break the Macchiatobin. This patch is dependent on the previous two patches, which are more about correct use of the API. I suspect if you try to backport the series, things will get very hairly very quickly. > > Please advise :) > > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > index 111b3b8239e1..ef44c6979a31 100644 > > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > @@ -3674,7 +3674,7 @@ static int mvpp2_open(struct net_device *dev) > > valid = true; > > } > > > > - if (priv->hw_version == MVPP22 && port->link_irq && !port->phylink) { > > + if (priv->hw_version == MVPP22 && port->link_irq) { > > err = request_irq(port->link_irq, mvpp2_link_status_isr, 0, > > dev->name, port); > > if (err) { > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up