From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8495C2D0C5 for ; Sat, 14 Dec 2019 08:24:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C65620706 for ; Sat, 14 Dec 2019 08:24:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726039AbfLNIYQ (ORCPT ); Sat, 14 Dec 2019 03:24:16 -0500 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:29485 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725372AbfLNIYP (ORCPT ); Sat, 14 Dec 2019 03:24:15 -0500 Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id xBE8O3MA002981; Sat, 14 Dec 2019 09:24:03 +0100 Date: Sat, 14 Dec 2019 09:24:03 +0100 From: Willy Tarreau To: Russell King - ARM Linux admin Cc: Jakub Kicinski , "David S. Miller" , Antoine Tenart , Andrew Lunn , Thomas Bogendoerfer , maxime.chevallier@bootlin.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: marvell: mvpp2: phylink requires the link interrupt Message-ID: <20191214082403.GA2959@1wt.eu> References: <20191213163403.2a054262@cakuba.netronome.com> <20191214075127.GX25745@shell.armlinux.org.uk> <20191214075602.GY25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191214075602.GY25745@shell.armlinux.org.uk> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Dec 14, 2019 at 07:56:02AM +0000, Russell King - ARM Linux admin wrote: > On Sat, Dec 14, 2019 at 07:51:27AM +0000, Russell King - ARM Linux admin wrote: > > On Fri, Dec 13, 2019 at 04:34:03PM -0800, Jakub Kicinski wrote: > > > On Tue, 10 Dec 2019 22:33:05 +0000, Russell King wrote: > > > > phylink requires the MAC to report when its link status changes when > > > > operating in inband modes. Failure to report link status changes > > > > means that phylink has no idea when the link events happen, which > > > > results in either the network interface's carrier remaining up or > > > > remaining permanently down. > > > > > > > > For example, with a fiber module, if the interface is brought up and > > > > link is initially established, taking the link down at the far end > > > > will cut the optical power. The SFP module's LOS asserts, we > > > > deactivate the link, and the network interface reports no carrier. > > > > > > > > When the far end is brought back up, the SFP module's LOS deasserts, > > > > but the MAC may be slower to establish link. If this happens (which > > > > in my tests is a certainty) then phylink never hears that the MAC > > > > has established link with the far end, and the network interface is > > > > stuck reporting no carrier. This means the interface is > > > > non-functional. > > > > > > > > Avoiding the link interrupt when we have phylink is basically not > > > > an option, so remove the !port->phylink from the test. > > > > > > > > Tested-by: Sven Auhagen > > > > Tested-by: Antoine Tenart > > > > Signed-off-by: Russell King > > > > > > Fixes: 4bb043262878 ("net: mvpp2: phylink support") ? > > > > > > Seems like you maybe didn't want this backported to stable hence > > > no fixes tag? > > > > Correct, because backporting just this patch will break the > > Macchiatobin. > > > > This patch is dependent on the previous two patches, which are more > > about correct use of the API. I suspect if you try to backport the > > series, things will get very hairly very quickly. > > Oh, sorry, too early, wrong patch. Yes, please add the fixes tag. I prefer :-) Because indeed I only have this one on top of 5.4.2 which solved the problem. You can even add my tested-by if you want (though I don't care). Thanks, Willy