From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D256C43603 for ; Sat, 14 Dec 2019 08:26:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1FE9720706 for ; Sat, 14 Dec 2019 08:26:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="bTehaJxn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726299AbfLNI0y (ORCPT ); Sat, 14 Dec 2019 03:26:54 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:40676 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725883AbfLNI0x (ORCPT ); Sat, 14 Dec 2019 03:26:53 -0500 Received: by mail-wr1-f68.google.com with SMTP id c14so1242356wrn.7 for ; Sat, 14 Dec 2019 00:26:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ifHRVJ+DQHL4cu36VQ6gKFWnRF/qcS7BFNg5rZGaKFk=; b=bTehaJxnrzsN7hD21n4gdPNm35iYGHim+o7ZnYkFhVC8QOj54zawqgNN3E+fT3IZlC WtFgtYdGOD20UzJ4wGLYNSFHlXu4xH4pkNEU4m10RBXzVRLHK5o8QoSRIW1Jfs6lB4g2 EB+kG1i+yXEgcH5QjtVwYo8HbVDB6ZBoJtVwUhZAvPv0JNXYb7qLIRLejLxIP4/iV9GC izIL++vdp1jU45HmgQqTGFdovgtz3I7dqwfszG9mqYfU7hx4UpauxGP7wFO037j9ywaf RJ/DHVSKEwmvD39x7yV7UDPlB6bFbojRTgHVzVflTuTTSIldZ4IOM2kgc9FGXhdldsi+ S6hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ifHRVJ+DQHL4cu36VQ6gKFWnRF/qcS7BFNg5rZGaKFk=; b=jukHFKU9rxgkso/8fWOamoEh+ls+hD8nPqvjXb6RU1A0VG97+TjceCALg7Ks93fxjm s+amG6NzYlK+XjzVXlLuQk/E6SPDGT+ykMwiqXn8xe1iTmR7fSnM/75YNeIutbuDPsPP FeT2x2WiHTaGOdcFXFoAalpkIC+AsBtJMmmkA20juzgdzjoK9nygN3jeZFdo0MQjd3GO PTZXj12f1dOsZhkO6re2eTl/7ZDkr7YcVzfqr6+lSLvLw2kn+3xBcUk2QS7N1G0N9eQo fSYdJ6Pjc9WRELzwO6Uz6SehdvdnsbljLzxsDqIzLBwww0asx/iE1EHQG9g9FigcEwf8 o0mQ== X-Gm-Message-State: APjAAAXCfIdsP3AtXSrZVjiPz5czOY+faTUH9lH+KAusQfxFnqbnTclB qumqfSenVDu/IJ9od8anronmhmJ1rrw= X-Google-Smtp-Source: APXvYqzQOhfjfrfXWxHUpCanCxoee+GJMqIKpYp7Ziopp8SZ3b80NJfjwr72yQKEdOwaojhOmZ5zPQ== X-Received: by 2002:adf:a109:: with SMTP id o9mr18723835wro.189.1576312011733; Sat, 14 Dec 2019 00:26:51 -0800 (PST) Received: from netronome.com (fred-musen.rivierenbuurt.horms.nl. [2001:470:7eb3:404:a2a4:c5ff:fe4c:9ce9]) by smtp.gmail.com with ESMTPSA id v14sm13079504wrm.28.2019.12.14.00.26.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Dec 2019 00:26:51 -0800 (PST) Date: Sat, 14 Dec 2019 09:26:50 +0100 From: Simon Horman To: Xin Long Cc: network dev , netfilter-devel@vger.kernel.org, davem@davemloft.net, Pablo Neira Ayuso Subject: Re: [PATCHv2 nf-next 3/5] netfilter: nft_tunnel: also dump ERSPAN_VERSION Message-ID: <20191214082649.GC5926@netronome.com> References: <46a6912e0996a23b79a6d52eaf9ed501a1dab86b.1576226965.git.lucien.xin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46a6912e0996a23b79a6d52eaf9ed501a1dab86b.1576226965.git.lucien.xin@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Dec 13, 2019 at 04:53:07PM +0800, Xin Long wrote: > This is not necessary, but it'll be easier to parse in userspace, > also given that other places like act_tunnel_key, cls_flower and > ip_tunnel_core are also doing so. > > Signed-off-by: Xin Long > Acked-by: Pablo Neira Ayuso Reviewed-by: Simon Horman > --- > net/netfilter/nft_tunnel.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/net/netfilter/nft_tunnel.c b/net/netfilter/nft_tunnel.c > index 6538895..b3a9b10 100644 > --- a/net/netfilter/nft_tunnel.c > +++ b/net/netfilter/nft_tunnel.c > @@ -479,6 +479,9 @@ static int nft_tunnel_opts_dump(struct sk_buff *skb, > htonl(opts->u.vxlan.gbp))) > return -1; > } else if (opts->flags & TUNNEL_ERSPAN_OPT) { > + if (nla_put_be32(skb, NFTA_TUNNEL_KEY_ERSPAN_VERSION, > + htonl(opts->u.erspan.version))) > + return -1; > switch (opts->u.erspan.version) { > case ERSPAN_VERSION: > if (nla_put_be32(skb, NFTA_TUNNEL_KEY_ERSPAN_V1_INDEX, > -- > 2.1.0 >