From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11434C43603 for ; Mon, 16 Dec 2019 09:04:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC3E920725 for ; Mon, 16 Dec 2019 09:04:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576487073; bh=JZKi27/ADaNAzPibrndV9zbPjqCG/CF7QSyH9Sw9OOg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zCnbGAJG/F7osaP43tQ+hUS6fx/wX1dwbCPS8i97PizYIq5AGi9axgc8nC9peabv6 9TEHJSpX25d/bX4gR9QX3xdVTLdBQGUD0egoZaJoXkNMBssyUB/i3JFD+Dutda4iXh Kk/9f3sXSjJvJ7JKy1mkzgmHYS6mklWETUM2E8uw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726818AbfLPJEb (ORCPT ); Mon, 16 Dec 2019 04:04:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:57540 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726016AbfLPJEa (ORCPT ); Mon, 16 Dec 2019 04:04:30 -0500 Received: from localhost (unknown [5.29.147.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8B95320725; Mon, 16 Dec 2019 09:04:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576487070; bh=JZKi27/ADaNAzPibrndV9zbPjqCG/CF7QSyH9Sw9OOg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qBify21WH5NuGIv32G3ec1YFei8ezros3sCjbqD0guUjT1sUfjxBuABgAmXTRt73S qTbAb4L8PChAfeJCMXgxYCF4dM2muGBeKIN6un2odFUdRJBnSmASyAZFrZQbx1s2N+ bRF9pdjeNMi0qNqL41bG04Ck4uVyBkKx4YoU3D+E= Date: Mon, 16 Dec 2019 11:04:26 +0200 From: Leon Romanovsky To: David Miller Cc: info@metux.net, linux-kernel@vger.kernel.org, jchapman@katalix.com, netdev@vger.kernel.org Subject: Re: [PATCH] net: l2tp: remove unneeded MODULE_VERSION() usage Message-ID: <20191216090426.GA66555@unreal> References: <20191212133613.25376-1-info@metux.net> <20191212.110354.354662228217900367.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191212.110354.354662228217900367.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Dec 12, 2019 at 11:03:54AM -0800, David Miller wrote: > From: "Enrico Weigelt, metux IT consult" > Date: Thu, 12 Dec 2019 14:36:13 +0100 > > > Remove MODULE_VERSION(), as it isn't needed at all: the only version > > making sense is the kernel version. > > > > Signed-off-by: Enrico Weigelt, metux IT consult > > Is there a plan to remove MODULE_VERSION across the entire kernel tree? > > Where is that documented? > > Otherwise what gave you the reason to make this change in the first place? Dave, see this conversation which I had two years ago with positive responses from many respectable developers. https://lists.linuxfoundation.org/pipermail/ksummit-discuss/2017-June/004421.html Greg's response: https://lists.linuxfoundation.org/pipermail/ksummit-discuss/2017-June/004441.html Linus's response: https://lists.linuxfoundation.org/pipermail/ksummit-discuss/2017-June/004426.html Thanks > > No context, no high level explanation of what's going on, so it's hard > to review and decide whether to accept your change sorry. > > At the least, you will have to write a more complete commit log message.