* [PATCH v1] net: ag71xx: fix compile warnings
@ 2019-12-16 6:44 Oleksij Rempel
2019-12-16 17:26 ` Andrew Lunn
2019-12-17 3:20 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Oleksij Rempel @ 2019-12-16 6:44 UTC (permalink / raw)
To: Jay Cliburn, Chris Snook, Andrew Lunn, David S. Miller
Cc: Oleksij Rempel, Pengutronix Kernel Team, netdev, linux-kernel
drivers/net/ethernet/atheros/ag71xx.c: In function 'ag71xx_probe':
drivers/net/ethernet/atheros/ag71xx.c:1776:30: warning: passing argument 2 of
'of_get_phy_mode' makes pointer from integer without a cast [-Wint-conversion]
In file included from drivers/net/ethernet/atheros/ag71xx.c:33:
./include/linux/of_net.h:15:69: note: expected 'phy_interface_t *'
{aka 'enum <anonymous> *'} but argument is of type 'int'
Fixes: 0c65b2b90d13c1 ("net: of_get_phy_mode: Change API to solve int/unit warnings")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
drivers/net/ethernet/atheros/ag71xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c
index e0958fc0bd57..3b02b55c2545 100644
--- a/drivers/net/ethernet/atheros/ag71xx.c
+++ b/drivers/net/ethernet/atheros/ag71xx.c
@@ -314,7 +314,7 @@ struct ag71xx {
struct ag71xx_desc *stop_desc;
dma_addr_t stop_desc_dma;
- int phy_if_mode;
+ phy_interface_t phy_if_mode;
struct phylink *phylink;
struct phylink_config phylink_config;
@@ -1773,7 +1773,7 @@ static int ag71xx_probe(struct platform_device *pdev)
eth_random_addr(ndev->dev_addr);
}
- err = of_get_phy_mode(np, ag->phy_if_mode);
+ err = of_get_phy_mode(np, &ag->phy_if_mode);
if (err) {
netif_err(ag, probe, ndev, "missing phy-mode property in DT\n");
goto err_free;
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] net: ag71xx: fix compile warnings
2019-12-16 6:44 [PATCH v1] net: ag71xx: fix compile warnings Oleksij Rempel
@ 2019-12-16 17:26 ` Andrew Lunn
2019-12-17 3:20 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2019-12-16 17:26 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Jay Cliburn, Chris Snook, David S. Miller,
Pengutronix Kernel Team, netdev, linux-kernel
On Mon, Dec 16, 2019 at 07:44:07AM +0100, Oleksij Rempel wrote:
> drivers/net/ethernet/atheros/ag71xx.c: In function 'ag71xx_probe':
> drivers/net/ethernet/atheros/ag71xx.c:1776:30: warning: passing argument 2 of
> 'of_get_phy_mode' makes pointer from integer without a cast [-Wint-conversion]
> In file included from drivers/net/ethernet/atheros/ag71xx.c:33:
> ./include/linux/of_net.h:15:69: note: expected 'phy_interface_t *'
> {aka 'enum <anonymous> *'} but argument is of type 'int'
>
> Fixes: 0c65b2b90d13c1 ("net: of_get_phy_mode: Change API to solve int/unit warnings")
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] net: ag71xx: fix compile warnings
2019-12-16 6:44 [PATCH v1] net: ag71xx: fix compile warnings Oleksij Rempel
2019-12-16 17:26 ` Andrew Lunn
@ 2019-12-17 3:20 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-12-17 3:20 UTC (permalink / raw)
To: o.rempel; +Cc: jcliburn, chris.snook, andrew, kernel, netdev, linux-kernel
From: Oleksij Rempel <o.rempel@pengutronix.de>
Date: Mon, 16 Dec 2019 07:44:07 +0100
> drivers/net/ethernet/atheros/ag71xx.c: In function 'ag71xx_probe':
> drivers/net/ethernet/atheros/ag71xx.c:1776:30: warning: passing argument 2 of
> 'of_get_phy_mode' makes pointer from integer without a cast [-Wint-conversion]
> In file included from drivers/net/ethernet/atheros/ag71xx.c:33:
> ./include/linux/of_net.h:15:69: note: expected 'phy_interface_t *'
> {aka 'enum <anonymous> *'} but argument is of type 'int'
>
> Fixes: 0c65b2b90d13c1 ("net: of_get_phy_mode: Change API to solve int/unit warnings")
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
This patch does not apply to the net tree.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-17 3:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-16 6:44 [PATCH v1] net: ag71xx: fix compile warnings Oleksij Rempel
2019-12-16 17:26 ` Andrew Lunn
2019-12-17 3:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).