From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A149C2D0C3 for ; Wed, 18 Dec 2019 06:18:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A3D721582 for ; Wed, 18 Dec 2019 06:18:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726492AbfLRGSr (ORCPT ); Wed, 18 Dec 2019 01:18:47 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:47244 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725799AbfLRGSr (ORCPT ); Wed, 18 Dec 2019 01:18:47 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id AC4F915005616; Tue, 17 Dec 2019 22:18:46 -0800 (PST) Date: Tue, 17 Dec 2019 22:18:46 -0800 (PST) Message-Id: <20191217.221846.1864258542284733289.davem@davemloft.net> To: alexchan@task.com.hk Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] llc2: Remove the condition operator in llc_stat_ev_rx_null_dsap_xid_c and llc_stat_ev_rx_null_dsap_test_c. From: David Miller In-Reply-To: <1576555237-4037-1-git-send-email-alexchan@task.com.hk> References: <1576340820-4929-1-git-send-email-alexchan@task.com.hk> <1576555237-4037-1-git-send-email-alexchan@task.com.hk> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 17 Dec 2019 22:18:46 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Chan Shu Tak, Alex" Date: Tue, 17 Dec 2019 12:00:36 +0800 > @@ -32,7 +32,7 @@ static int llc_stat_ev_rx_null_dsap_xid_c(struct sk_buff *skb) > return LLC_PDU_IS_CMD(pdu) && /* command PDU */ > LLC_PDU_TYPE_IS_U(pdu) && /* U type PDU */ > LLC_U_PDU_CMD(pdu) == LLC_1_PDU_CMD_XID && > - !pdu->dsap ? 1 : 0; /* NULL DSAP value */ > + !pdu->dsap; /* NULL DSAP value */ This isn't a v2 of your patch, it's a patch against v1 of your patch. Please do this properly, thank you.