From: Greg KH <gregkh@linuxfoundation.org>
To: Aviraj CJ <acj@cisco.com>
Cc: peppe.cavallaro@st.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
xe-linux-external@cisco.com
Subject: Re: [PATCH stable v4.4 1/2] net: stmmac: use correct DMA buffer size in the RX descriptor
Date: Tue, 17 Dec 2019 08:51:32 +0100 [thread overview]
Message-ID: <20191217075132.GC2474507@kroah.com> (raw)
In-Reply-To: <20191217055228.57282-1-acj@cisco.com>
On Mon, Dec 16, 2019 at 09:52:27PM -0800, Aviraj CJ wrote:
> upstream 583e6361414903c5206258a30e5bd88cb03c0254 commit
>
> We always program the maximum DMA buffer size into the receive descriptor,
> although the allocated size may be less. E.g. with the default MTU size
> we allocate only 1536 bytes. If somebody sends us a bigger frame, then
> memory may get corrupted.
>
> Program DMA using exact buffer sizes.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> [acj: backport to v4.4 -stable :
> - Modified patch since v4.4 driver has no support for Big endian
> - Skipped the section modifying non-existent functions in dwmac4_descs.c and
> dwxgmac2_descs.c ]
> Signed-off-by: Aviraj CJ <acj@cisco.com>
I can't take stable patches for an older tree and have it "skip" newer
stable trees. To be specific, this patch is already in the 4.19.41
release, but if I were to take it into the 4.4.y tree, then anyone
upgrading to 4.9.y or 4.14.y afterward would run into the same issue.
So can you also send backports to 4.9.y and 4.14.y so that I can take
this fix into all trees?
Same for patch 2/2.
thanks,
greg k-h
next prev parent reply other threads:[~2019-12-17 7:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 5:52 [PATCH stable v4.4 1/2] net: stmmac: use correct DMA buffer size in the RX descriptor Aviraj CJ
2019-12-17 5:52 ` [PATCH stable v4.4 2/2] net: stmmac: don't stop NAPI processing when dropping a packet Aviraj CJ
2019-12-17 7:51 ` Greg KH [this message]
2020-01-26 18:27 ` [PATCH stable v4.4 1/2] net: stmmac: use correct DMA buffer size in the RX descriptor Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217075132.GC2474507@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=acj@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=stable@vger.kernel.org \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).