From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BA75C3F68F for ; Wed, 18 Dec 2019 09:47:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 132AD21D7D for ; Wed, 18 Dec 2019 09:47:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="I6WLoW2q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726786AbfLRJr4 (ORCPT ); Wed, 18 Dec 2019 04:47:56 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:40111 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726551AbfLRJr4 (ORCPT ); Wed, 18 Dec 2019 04:47:56 -0500 Received: by mail-wr1-f67.google.com with SMTP id c14so1514480wrn.7 for ; Wed, 18 Dec 2019 01:47:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YWK6tplw8qlGD2BEjCDaCak/uVHFXrMGjJQnLjUJJTU=; b=I6WLoW2qYlf1eUT69t6WTES1iib/TEzwfT9cBjSpL/jHFprIhMnvz1o9eqjhduXSVU fVOJIZXZsEOdjM08L+Ruzkw6GQIqFZSf+z9rjrtWzds8OWvDc0rsZZzkrQpialt8dCUc +BOwJiOJqYP6Lm3D7VmFYoXpk7YAQW+CS16MWGwkj3mVY1rOyumKQjcidj10ERn7Pn66 EhErQAvYslTznTyjbaPReDIEX9K3+E3hezbEKkudzKWmwPEq55PzcSqjYE6PAHZXFswl e1niJEKCJMcUPVYo0RKGv2UAKZekhqh8JCgBoT+RHreSEpNZYoCk2zsMDGjHMI1jC1fx rU2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YWK6tplw8qlGD2BEjCDaCak/uVHFXrMGjJQnLjUJJTU=; b=SKjyuYxKgGQi6dnkGDM1HG6jxsoIUuXBPm5/g8aPtCP/evO2Gaw0Viaw58lS8W15ml uX9k8oBtzi+N/Hsv4IxSUsEd1oMbS1wMKEvX7JiHgK/aAoaGxg3h4785FfrAW9+BNpDd gsCXuPqLRQBmetKWqhnRLoKqJ/8T1SsSl4ocKwT/nklLaHKk2EZaWk7qRhmL4w1Osk3F A5n+pbQ8nGR9uVAnuhH0aNUQzh6igvBPKaTyVM7WSe5+8W4+4ybrRaKehADJa7hx8e9o lTPqNAj2PPrJiapMseMwaBn1alyt9FDIe7daw3zt12+HTkeyrhS9ZjKSLuwIdMOnE4Js TeyQ== X-Gm-Message-State: APjAAAW+yMFQprdhcl8B8M9nvYiRM7e+PPlq1zOzV5gungmmVp1hYSpP sYnosJ0QW37jzoIEy8vuvb6tww== X-Google-Smtp-Source: APXvYqw42ArB3QvbXO16aMF2GJ30kEWLpD0ZKuyNi5JuD/bG24Y7Y7ZWuRL2bQyQRlYS2W2yO77FnQ== X-Received: by 2002:a5d:4481:: with SMTP id j1mr1818077wrq.348.1576662474256; Wed, 18 Dec 2019 01:47:54 -0800 (PST) Received: from netronome.com ([2001:982:756:703:d63d:7eff:fe99:ac9d]) by smtp.gmail.com with ESMTPSA id n16sm1937883wro.88.2019.12.18.01.47.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2019 01:47:53 -0800 (PST) Date: Wed, 18 Dec 2019 10:47:53 +0100 From: Simon Horman To: Pablo Neira Ayuso Cc: Xin Long , network dev , netfilter-devel@vger.kernel.org, davem@davemloft.net Subject: Re: [PATCHv2 nf-next 2/5] netfilter: nft_tunnel: add the missing ERSPAN_VERSION nla_policy Message-ID: <20191218094752.GA22367@netronome.com> References: <7bcaa9e0507fa9a5b6a48f56768a179281bf4ab2.1576226965.git.lucien.xin@gmail.com> <20191214082630.GB5926@netronome.com> <20191217213945.5ti7ktxc725emec3@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191217213945.5ti7ktxc725emec3@salvia> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Dec 17, 2019 at 10:39:45PM +0100, Pablo Neira Ayuso wrote: > On Sat, Dec 14, 2019 at 09:26:31AM +0100, Simon Horman wrote: > > On Fri, Dec 13, 2019 at 04:53:06PM +0800, Xin Long wrote: > > > ERSPAN_VERSION is an attribute parsed in kernel side, nla_policy > > > type should be added for it, like other attributes. > > > > > > Fixes: af308b94a2a4 ("netfilter: nf_tables: add tunnel support") > > > > Is this really a fix? > > I think so. Netlink attribute validation for > NFTA_TUNNEL_KEY_ERSPAN_VERSION is missing. Ok, I accept that reasoning.