From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3D95C43603 for ; Thu, 19 Dec 2019 17:52:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 777EF206D8 for ; Thu, 19 Dec 2019 17:52:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726935AbfLSRwM (ORCPT ); Thu, 19 Dec 2019 12:52:12 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:39928 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726836AbfLSRwL (ORCPT ); Thu, 19 Dec 2019 12:52:11 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id DC3A515307A73; Thu, 19 Dec 2019 09:52:10 -0800 (PST) Date: Thu, 19 Dec 2019 09:52:08 -0800 (PST) Message-Id: <20191219.095208.349922153806345978.davem@davemloft.net> To: lorenzo@google.com Cc: nhorman@tuxdriver.com, zenczykowski@gmail.com, maze@google.com, netdev@vger.kernel.org, stranche@codeaurora.org, subashab@codeaurora.org, edumazet@google.com, linux-sctp@vger.kernel.org Subject: Re: [PATCH] net: introduce ip_local_unbindable_ports sysctl From: David Miller In-Reply-To: References: <20191219131700.GA1159@hmswarspite.think-freely.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 19 Dec 2019 09:52:11 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Lorenzo Colitti Date: Thu, 19 Dec 2019 23:02:32 +0900 > But in any case, the result would be more complicated to use and > maintain, and it would likely also be less realistic, such that a > sophisticated conformance test might still find that the port was > actually bound. Other users of the kernel wouldn't get to use this > sysctl, and the userspace code can't be easily reused in other > open-source projects, so the community gets nothing useful. That > doesn't seem great. The same argument can be made about kernel changes that are only needed by Android because they refuse to use a userspace solution that frankly can do the job. Can you see why these Android special case discussions are so frustrating for kernel devs? And using the "we'll just have a local kernel change in the Android kernel" threat as leverage in the discussion... yeah very unpleasant indeed.