From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] net: phy: ensure that phy IDs are correctly typed
Date: Thu, 19 Dec 2019 10:24:56 +0000 [thread overview]
Message-ID: <20191219102455.GA25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <E1ihsvI-0001bz-3t@rmk-PC.armlinux.org.uk>
On Thu, Dec 19, 2019 at 10:20:48AM +0000, Russell King wrote:
> PHY IDs are 32-bit unsigned quantities. Ensure that they are always
> treated as such, and not passed around as "int"s.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Fixes: 13d0ab6750b2 ("net: phy: check return code when requesting PHY driver module")
> ---
> drivers/net/phy/phy_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> index daaeae5f2d96..68d4d49286d7 100644
> --- a/drivers/net/phy/phy_device.c
> +++ b/drivers/net/phy/phy_device.c
> @@ -551,7 +551,7 @@ static const struct device_type mdio_bus_phy_type = {
> .pm = MDIO_BUS_PHY_PM_OPS,
> };
>
> -static int phy_request_driver_module(struct phy_device *dev, int phy_id)
> +static int phy_request_driver_module(struct phy_device *dev, u32 phy_id)
> {
> int ret;
>
> --
> 2.20.1
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2019-12-19 10:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 10:20 [PATCH] net: phy: ensure that phy IDs are correctly typed Russell King
2019-12-19 10:24 ` Russell King - ARM Linux admin [this message]
2019-12-19 21:01 ` Andrew Lunn
2019-12-19 22:40 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219102455.GA25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).