From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=c9up=2J=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1
	autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 688F6C43603
	for <netdev@archiver.kernel.org>; Thu, 19 Dec 2019 21:26:32 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 4799724679
	for <netdev@archiver.kernel.org>; Thu, 19 Dec 2019 21:26:32 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727229AbfLSV02 (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Thu, 19 Dec 2019 16:26:28 -0500
Received: from www62.your-server.de ([213.133.104.62]:60496 "EHLO
        www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726880AbfLSV02 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 19 Dec 2019 16:26:28 -0500
Received: from 31.249.197.178.dynamic.dsl-lte-bonding.lssmb00p-msn.res.cust.swisscom.ch ([178.197.249.31] helo=localhost)
        by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256)
        (Exim 4.89_1)
        (envelope-from <daniel@iogearbox.net>)
        id 1ii3JS-0005a8-Jf; Thu, 19 Dec 2019 22:26:26 +0100
Date:   Thu, 19 Dec 2019 22:26:26 +0100
From:   Daniel Borkmann <daniel@iogearbox.net>
To:     Aditya Pakki <pakki001@umn.edu>
Cc:     kjlu@umn.edu, Alexei Starovoitov <ast@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        Andrii Nakryiko <andriin@fb.com>, netdev@vger.kernel.org,
        bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] bpf: Remove unnecessary assertion on fp_old
Message-ID: <20191219212626.GA19344@pc-9.home>
References: <20191219175735.19231-1-pakki001@umn.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191219175735.19231-1-pakki001@umn.edu>
User-Agent: Mutt/1.12.1 (2019-06-15)
X-Authenticated-Sender: daniel@iogearbox.net
X-Virus-Scanned: Clear (ClamAV 0.101.4/25668/Thu Dec 19 10:55:58 2019)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Thu, Dec 19, 2019 at 11:57:35AM -0600, Aditya Pakki wrote:
> The two callers of bpf_prog_realloc - bpf_patch_insn_single and
> bpf_migrate_filter dereference the struct fp_old, before passing
> it to the function. Thus assertion to check fp_old is unnecessary
> and can be removed.
> 
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>

Applied, thanks!