From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: syzbot <syzbot+9a1bc632e78a1a98488b@syzkaller.appspotmail.com>
Cc: davem@davemloft.net, linux-kernel@vger.kernel.org,
linux-sctp@vger.kernel.org, lucien.xin@gmail.com,
netdev@vger.kernel.org, nhorman@tuxdriver.com,
syzkaller-bugs@googlegroups.com, vyasevich@gmail.com
Subject: Re: general protection fault in sctp_stream_free (2)
Date: Fri, 20 Dec 2019 12:28:10 -0300 [thread overview]
Message-ID: <20191220152810.GI4444@localhost.localdomain> (raw)
In-Reply-To: <0000000000001b6443059a1a815d@google.com>
On Thu, Dec 19, 2019 at 07:45:09PM -0800, syzbot wrote:
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit: 6fa9a115 Merge branch 'stmmac-fixes'
> git tree: net
> console output: https://syzkaller.appspot.com/x/log.txt?x=10c4fe99e00000
> kernel config: https://syzkaller.appspot.com/x/.config?x=216dca5e1758db87
> dashboard link: https://syzkaller.appspot.com/bug?extid=9a1bc632e78a1a98488b
> compiler: gcc (GCC) 9.0.0 20181231 (experimental)
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=178ada71e00000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=144f23a6e00000
>
> The bug was bisected to:
>
> commit 951c6db954a1adefab492f6da805decacabbd1a7
> Author: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> Date: Tue Dec 17 01:01:16 2019 +0000
>
> sctp: fix memleak on err handling of stream initialization
Ouch... this wasn't a good fix.
When called from sctp_stream_init(), it is doing the right thing.
But when called from sctp_send_add_streams(), it can't free the
genradix. Ditto from sctp_process_strreset_addstrm_in().
next prev parent reply other threads:[~2019-12-20 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 3:45 general protection fault in sctp_stream_free (2) syzbot
2019-12-20 15:28 ` Marcelo Ricardo Leitner [this message]
2019-12-20 16:05 ` Marcelo Ricardo Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220152810.GI4444@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=syzbot+9a1bc632e78a1a98488b@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).