From: Borislav Petkov <bp@alien8.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Antoine Tenart <antoine.tenart@bootlin.com>,
"David S . Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: mdio: Add missing inline to of_mdiobus_child_is_phy() dummy
Date: Mon, 23 Dec 2019 12:10:37 +0100 [thread overview]
Message-ID: <20191223111037.GA25148@zn.tnic> (raw)
In-Reply-To: <20191223100321.7364-1-geert@linux-m68k.org>
On Mon, Dec 23, 2019 at 11:03:21AM +0100, Geert Uytterhoeven wrote:
> If CONFIG_OF_MDIO=n:
>
> drivers/net/phy/mdio_bus.c:23:
> include/linux/of_mdio.h:58:13: warning: ‘of_mdiobus_child_is_phy’ defined but not used [-Wunused-function]
> static bool of_mdiobus_child_is_phy(struct device_node *child)
> ^~~~~~~~~~~~~~~~~~~~~~~
>
> Fix this by adding the missing "inline" keyword.
>
> Fixes: 0aa4d016c043d16a ("of: mdio: export of_mdiobus_child_is_phy")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> include/linux/of_mdio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/of_mdio.h b/include/linux/of_mdio.h
> index 79bc82e30c02333d..491a2b7e77c1e906 100644
> --- a/include/linux/of_mdio.h
> +++ b/include/linux/of_mdio.h
> @@ -55,7 +55,7 @@ static inline int of_mdio_parse_addr(struct device *dev,
> }
>
> #else /* CONFIG_OF_MDIO */
> -static bool of_mdiobus_child_is_phy(struct device_node *child)
> +static inline bool of_mdiobus_child_is_phy(struct device_node *child)
> {
> return false;
> }
> --
I'm seeing it too with rc3.
Acked-by: Borislav Petkov <bp@suse.de>
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2019-12-23 11:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 10:03 [PATCH] of: mdio: Add missing inline to of_mdiobus_child_is_phy() dummy Geert Uytterhoeven
2019-12-23 10:51 ` Andrew Lunn
2019-12-23 11:10 ` Borislav Petkov [this message]
2019-12-26 23:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191223111037.GA25148@zn.tnic \
--to=bp@alien8.de \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=geert@linux-m68k.org \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).