From: "Amadeusz Sławiński" <amade@asmblr.net>
To: Ping-Ke Shih <pkshih@realtek.com>, Kalle Valo <kvalo@codeaurora.org>
Cc: "David S . Miller" <davem@davemloft.net>,
"Larry Finger" <Larry.Finger@lwfinger.net>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, "Amadeusz Sławiński" <amade@asmblr.net>
Subject: [PATCH 3/9] rtlwifi: rtl8192ce: Make functions static & rm sw.h
Date: Mon, 23 Dec 2019 13:37:09 +0100 [thread overview]
Message-ID: <20191223123715.7177-4-amade@asmblr.net> (raw)
In-Reply-To: <20191223123715.7177-1-amade@asmblr.net>
Some of functions which were exposed in sw.h, are only used in sw.c, so
just make them static. The rtl92c_init_var_map function is not defined
anywhere, while declared in sw.h. Two other functions are also declared
in phy.h (which is included in sw.c) and their definitions are in phy.c
Overall sw.h is unnecessary and can be removed.
Signed-off-by: Amadeusz Sławiński <amade@asmblr.net>
---
.../net/wireless/realtek/rtlwifi/rtl8192ce/sw.c | 5 ++---
.../net/wireless/realtek/rtlwifi/rtl8192ce/sw.h | 15 ---------------
2 files changed, 2 insertions(+), 18 deletions(-)
delete mode 100644 drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.h
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.c
index 900788e4018c..ed68c850f9a2 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.c
@@ -14,7 +14,6 @@
#include "../rtl8192c/phy_common.h"
#include "hw.h"
#include "rf.h"
-#include "sw.h"
#include "trx.h"
#include "led.h"
@@ -65,7 +64,7 @@ static void rtl92c_init_aspm_vars(struct ieee80211_hw *hw)
rtlpci->const_support_pciaspm = rtlpriv->cfg->mod_params->aspm_support;
}
-int rtl92c_init_sw_vars(struct ieee80211_hw *hw)
+static int rtl92c_init_sw_vars(struct ieee80211_hw *hw)
{
int err;
struct rtl_priv *rtlpriv = rtl_priv(hw);
@@ -161,7 +160,7 @@ int rtl92c_init_sw_vars(struct ieee80211_hw *hw)
return 0;
}
-void rtl92c_deinit_sw_vars(struct ieee80211_hw *hw)
+static void rtl92c_deinit_sw_vars(struct ieee80211_hw *hw)
{
struct rtl_priv *rtlpriv = rtl_priv(hw);
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.h b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.h
deleted file mode 100644
index f2d121a60159..000000000000
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.h
+++ /dev/null
@@ -1,15 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-/* Copyright(c) 2009-2012 Realtek Corporation.*/
-
-#ifndef __RTL92CE_SW_H__
-#define __RTL92CE_SW_H__
-
-int rtl92c_init_sw_vars(struct ieee80211_hw *hw);
-void rtl92c_deinit_sw_vars(struct ieee80211_hw *hw);
-void rtl92c_init_var_map(struct ieee80211_hw *hw);
-bool _rtl92ce_phy_config_bb_with_headerfile(struct ieee80211_hw *hw,
- u8 configtype);
-bool _rtl92ce_phy_config_bb_with_pgheaderfile(struct ieee80211_hw *hw,
- u8 configtype);
-
-#endif
--
2.24.1
next prev parent reply other threads:[~2019-12-23 12:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 12:37 [PATCH 0/9] rtlwifi: Cleanups Amadeusz Sławiński
2019-12-23 12:37 ` [PATCH 1/9] rtlwifi: rtl8192cu: Fix typo Amadeusz Sławiński
2020-01-26 15:40 ` Kalle Valo
2019-12-23 12:37 ` [PATCH 2/9] rtlwifi: rtl8188ee: Make functions static & rm sw.h Amadeusz Sławiński
2019-12-23 12:37 ` Amadeusz Sławiński [this message]
2019-12-23 12:37 ` [PATCH 4/9] rtlwifi: rtl8192cu: Remove sw.h header Amadeusz Sławiński
2019-12-23 12:37 ` [PATCH 5/9] rtlwifi: rtl8192ee: Make functions static & rm sw.h Amadeusz Sławiński
2019-12-23 12:37 ` [PATCH 6/9] rtlwifi: rtl8192se: Remove sw.h header Amadeusz Sławiński
2019-12-23 12:37 ` [PATCH 7/9] rtlwifi: rtl8723ae: Make functions static & rm sw.h Amadeusz Sławiński
2019-12-23 12:37 ` [PATCH 8/9] rtlwifi: rtl8723be: " Amadeusz Sławiński
2019-12-23 12:37 ` [PATCH 9/9] rtlwifi: rtl8821ae: " Amadeusz Sławiński
2019-12-24 1:57 ` [PATCH 0/9] rtlwifi: Cleanups Pkshih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191223123715.7177-4-amade@asmblr.net \
--to=amade@asmblr.net \
--cc=Larry.Finger@lwfinger.net \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).