From: Andrew Lunn <andrew@lunn.ch>
To: Mao Wenan <maowenan@huawei.com>
Cc: vivien.didelot@gmail.com, f.fainelli@gmail.com,
davem@davemloft.net, linux@rempel-privat.de,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net: dsa: drop pointless static qualifier in ar9331_sw_mbus_init
Date: Tue, 24 Dec 2019 12:25:15 +0100 [thread overview]
Message-ID: <20191224112515.GE3395@lunn.ch> (raw)
In-Reply-To: <20191224024059.184847-1-maowenan@huawei.com>
On Tue, Dec 24, 2019 at 10:40:59AM +0800, Mao Wenan wrote:
> There is no need to have the 'T *v' variable static
What does 'T *v' mean?
The patch itself looks O.K, but the description should be better, and
the subject line.
Andrew
next prev parent reply other threads:[~2019-12-24 11:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-24 2:40 [PATCH net-next] net: dsa: drop pointless static qualifier in ar9331_sw_mbus_init Mao Wenan
2019-12-24 10:45 ` Marek Behun
2019-12-24 11:25 ` Andrew Lunn [this message]
2019-12-24 11:58 ` [PATCH net-next v2] net: dsa: qca: ar9331: " Mao Wenan
2019-12-24 12:10 ` Oleksij Rempel
2019-12-24 12:34 ` Andrew Lunn
2019-12-28 0:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191224112515.GE3395@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=maowenan@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).