From: Stephen Hemminger <stephen@networkplumber.org>
To: Antony Antony <antony@phenome.org>
Cc: netdev@vger.kernel.org, Matt Ellison <matt@arroyo.io>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>
Subject: Re: [PATCH] ip: xfrm if_id -ve value is error
Date: Wed, 25 Dec 2019 12:38:25 -0800 [thread overview]
Message-ID: <20191225123825.4e4ddef9@hermes.lan> (raw)
In-Reply-To: <20191219141803.3453-1-antony@phenome.org>
On Thu, 19 Dec 2019 15:18:03 +0100
Antony Antony <antony@phenome.org> wrote:
> if_id is u32, error on -ve values instead of setting to 0
>
> after :
> ip link add ipsec1 type xfrm dev lo if_id -10
> Error: argument "-10" is wrong: if_id value is invalid
>
> before : note xfrm if_id 0
> ip link add ipsec1 type xfrm dev lo if_id -10
> ip -d link show dev ipsec1
> 9: ipsec1@lo: <NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
> link/none 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 1500
> xfrm if_id 0 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
>
> Fixes: 286446c1e8c ("ip: support for xfrm interfaces")
>
> Signed-off-by: Antony Antony <antony@phenome.org>
Applied.
next prev parent reply other threads:[~2019-12-25 20:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 14:18 [PATCH] ip: xfrm if_id -ve value is error Antony Antony
2019-12-25 20:38 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-04-09 19:44 Antony Antony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191225123825.4e4ddef9@hermes.lan \
--to=stephen@networkplumber.org \
--cc=antony@phenome.org \
--cc=matt@arroyo.io \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).