From: Stephen Hemminger <stephen@networkplumber.org>
To: Andy Roulin <aroulin@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, dsahern@gmail.com,
nikolay@cumulusnetworks.com, roopa@cumulusnetworks.com,
j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net
Subject: Re: [PATCH net-next v2] bonding: rename AD_STATE_* to LACP_STATE_*
Date: Thu, 26 Dec 2019 18:20:42 -0800 [thread overview]
Message-ID: <20191226182042.3ca9cd94@hermes.lan> (raw)
In-Reply-To: <1577367717-3971-1-git-send-email-aroulin@cumulusnetworks.com>
On Thu, 26 Dec 2019 05:41:57 -0800
Andy Roulin <aroulin@cumulusnetworks.com> wrote:
> diff --git a/include/uapi/linux/if_bonding.h b/include/uapi/linux/if_bonding.h
> index 6829213a54c5..45f3750aa861 100644
> --- a/include/uapi/linux/if_bonding.h
> +++ b/include/uapi/linux/if_bonding.h
> @@ -96,14 +96,14 @@
> #define BOND_XMIT_POLICY_ENCAP34 4 /* encapsulated layer 3+4 */
>
> /* 802.3ad port state definitions (43.4.2.2 in the 802.3ad standard) */
> -#define AD_STATE_LACP_ACTIVITY 0x1
> -#define AD_STATE_LACP_TIMEOUT 0x2
> -#define AD_STATE_AGGREGATION 0x4
> -#define AD_STATE_SYNCHRONIZATION 0x8
> -#define AD_STATE_COLLECTING 0x10
> -#define AD_STATE_DISTRIBUTING 0x20
> -#define AD_STATE_DEFAULTED 0x40
> -#define AD_STATE_EXPIRED 0x80
> +#define LACP_STATE_LACP_ACTIVITY 0x1
> +#define LACP_STATE_LACP_TIMEOUT 0x2
> +#define LACP_STATE_AGGREGATION 0x4
> +#define LACP_STATE_SYNCHRONIZATION 0x8
> +#define LACP_STATE_COLLECTING 0x10
> +#define LACP_STATE_DISTRIBUTING 0x20
> +#define LACP_STATE_DEFAULTED 0x40
> +#define LACP_STATE_EXPIRED 0x80
You can't change definitions of headers in userspace api
without breaking compatibility.
next prev parent reply other threads:[~2019-12-27 2:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 13:41 [PATCH net-next v2] bonding: rename AD_STATE_* to LACP_STATE_* Andy Roulin
2019-12-26 21:09 ` David Miller
2019-12-27 2:20 ` Stephen Hemminger [this message]
2019-12-27 4:21 ` David Ahern
2019-12-27 22:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191226182042.3ca9cd94@hermes.lan \
--to=stephen@networkplumber.org \
--cc=andy@greyhouse.net \
--cc=aroulin@cumulusnetworks.com \
--cc=dsahern@gmail.com \
--cc=j.vosburgh@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).