From: Vladimir Oltean <olteanv@gmail.com>
To: davem@davemloft.net, jakub.kicinski@netronome.com
Cc: richardcochran@gmail.com, f.fainelli@gmail.com,
vivien.didelot@gmail.com, andrew@lunn.ch, netdev@vger.kernel.org,
Vladimir Oltean <olteanv@gmail.com>
Subject: [PATCH net 0/2] The DSA TX timestamping situation
Date: Fri, 27 Dec 2019 02:44:33 +0200 [thread overview]
Message-ID: <20191227004435.21692-1-olteanv@gmail.com> (raw)
This series is the moral v2 of "[PATCH net] net: dsa: sja1105: Fix
double delivery of TX timestamps to socket error queue" [0] which did
not manage to convince public opinion (actually it didn't convince me
neither).
This fixes PTP timestamping on one particular board, where the DSA
switch is sja1105 and the master is gianfar. Unfortunately there is no
way to make the fix more general without committing logical
inaccuracies: the SKBTX_IN_PROGRESS flag does serve a purpose, even if
the sja1105 driver is not using it now: it prevents delivering a SW
timestamp to the app socket when the HW timestamp will be provided. So
not setting this flag (the approach from v1) might create avoidable
complications in the future (not to mention that there isn't any
satisfactory explanation on why that would be the correct solution).
So the goal of this change set is to create a more strict framework for
DSA master devices when attached to PTP switches, and to fix the first
master driver that is overstepping its duties and is delivering
unsolicited TX timestamps.
[0]: https://www.spinics.net/lists/netdev/msg619699.html
Vladimir Oltean (2):
gianfar: Fix TX timestamping with stacked (DSA and PHY) drivers
net: dsa: Deny PTP on master if switch supports it
drivers/net/ethernet/freescale/gianfar.c | 10 +++++---
net/dsa/master.c | 30 ++++++++++++++++++++++++
2 files changed, 37 insertions(+), 3 deletions(-)
--
2.17.1
next reply other threads:[~2019-12-27 0:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 0:44 Vladimir Oltean [this message]
2019-12-27 0:44 ` [PATCH net 1/2] gianfar: Fix TX timestamping with stacked (DSA and PHY) drivers Vladimir Oltean
2019-12-27 18:00 ` Richard Cochran
2019-12-27 0:44 ` [PATCH net 2/2] net: dsa: Deny PTP on master if switch supports it Vladimir Oltean
2019-12-27 17:51 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191227004435.21692-1-olteanv@gmail.com \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).