From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAB2EC2D0C6 for ; Fri, 27 Dec 2019 17:47:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A26F320740 for ; Fri, 27 Dec 2019 17:47:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577468854; bh=+f//3drd10J8Z3BKDw7O9ABlKDWXI0f2Xrar4JKTvbs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JeH+JNgWXElAzmp9dXRLUTgy+B6b/aItOeRSEynZmdgKI0kU+aD58gI+BPmDvC4Tp qE26m0lu/jX4aW0xDna0vL8S6EB3UCYbh4TDOFL5UCD6xu4dTh0RuGTAQqDUwzpM+k n1LkVXKyISygyKD9RnxvuxXL9Fcy/g2AqMaYlgh0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728465AbfL0Rrb (ORCPT ); Fri, 27 Dec 2019 12:47:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:43324 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728629AbfL0Ro6 (ORCPT ); Fri, 27 Dec 2019 12:44:58 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2CC2521927; Fri, 27 Dec 2019 17:44:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577468697; bh=+f//3drd10J8Z3BKDw7O9ABlKDWXI0f2Xrar4JKTvbs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ViML4qxzlb+yQLEYLT4tpwk9Z7CxFlBXihLgAGDFSv8s//74lkAvJz8cq4Szgm5jH c+5DF8tgEdydX53QwDfe1dtrpbnEDqIpYzyyfRZYcKsVB5SVGShnWeZ+z3H8/D0Ad1 9rHP4xriiEbXQbb98GxlYG/tygshXag2tSvKI9dQ= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Taehee Yoo , Jakub Kicinski , Sasha Levin , osmocom-net-gprs@lists.osmocom.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 54/84] gtp: avoid zero size hashtable Date: Fri, 27 Dec 2019 12:43:22 -0500 Message-Id: <20191227174352.6264-54-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191227174352.6264-1-sashal@kernel.org> References: <20191227174352.6264-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Taehee Yoo [ Upstream commit 6a902c0f31993ab02e1b6ea7085002b9c9083b6a ] GTP default hashtable size is 1024 and userspace could set specific hashtable size with IFLA_GTP_PDP_HASHSIZE. If hashtable size is set to 0 from userspace, hashtable will not work and panic will occur. Fixes: 459aa660eb1d ("gtp: add initial driver for datapath of GPRS Tunneling Protocol (GTP-U)") Signed-off-by: Taehee Yoo Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/gtp.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index d64ebf0f9677..eeae8617f7ec 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -664,10 +664,13 @@ static int gtp_newlink(struct net *src_net, struct net_device *dev, if (err < 0) return err; - if (!data[IFLA_GTP_PDP_HASHSIZE]) + if (!data[IFLA_GTP_PDP_HASHSIZE]) { hashsize = 1024; - else + } else { hashsize = nla_get_u32(data[IFLA_GTP_PDP_HASHSIZE]); + if (!hashsize) + hashsize = 1024; + } err = gtp_hashtable_new(gtp, hashsize); if (err < 0) -- 2.20.1