From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9465AC2D0CE for ; Fri, 27 Dec 2019 17:47:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 66BEF206CB for ; Fri, 27 Dec 2019 17:47:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577468825; bh=BRBDoL0jBkrn1RFaEcc86qvinIIVWonsh5GoK2iFjM8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=PkZ73oAE1SuxqVxk//FyR4Tufy5buzOljW0aHgsyZglIDd6A0J3EjfRF42fsldoya 5LkLJNc993tZQrf1ILHFm4mW5s4T+Lp6j6pH2Lg20Bg17mYS5W41aFBhPDriGIffZY CFUXOIaHGNmC8BjGiB93CQl+LVyaeq2C7IKctJkU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728442AbfL0RrC (ORCPT ); Fri, 27 Dec 2019 12:47:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:43464 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728281AbfL0RpC (ORCPT ); Fri, 27 Dec 2019 12:45:02 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 72EB8222C2; Fri, 27 Dec 2019 17:45:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577468702; bh=BRBDoL0jBkrn1RFaEcc86qvinIIVWonsh5GoK2iFjM8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gAgOldOoRPtxaoZs1NKP6/9Nar9DKB/DgfHXBYNc66PQgQsxZncOMWH6Wu47MV3Ib pXXefPwaslduUS1CNvLAuto6VFb36h2V8+iF4Ox95Fd6HGq0R14GPHXwa4DEs0x7CJ G72clSqqwVHqlr158iuAJLtIjzJEIHCDltl1sINw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Aditya Pakki , Johannes Berg , Sasha Levin , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 58/84] rfkill: Fix incorrect check to avoid NULL pointer dereference Date: Fri, 27 Dec 2019 12:43:26 -0500 Message-Id: <20191227174352.6264-58-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191227174352.6264-1-sashal@kernel.org> References: <20191227174352.6264-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Aditya Pakki [ Upstream commit 6fc232db9e8cd50b9b83534de9cd91ace711b2d7 ] In rfkill_register, the struct rfkill pointer is first derefernced and then checked for NULL. This patch removes the BUG_ON and returns an error to the caller in case rfkill is NULL. Signed-off-by: Aditya Pakki Link: https://lore.kernel.org/r/20191215153409.21696-1-pakki001@umn.edu Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/rfkill/core.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/net/rfkill/core.c b/net/rfkill/core.c index 1355f5ca8d22..2c0ac44741a0 100644 --- a/net/rfkill/core.c +++ b/net/rfkill/core.c @@ -1014,10 +1014,13 @@ static void rfkill_sync_work(struct work_struct *work) int __must_check rfkill_register(struct rfkill *rfkill) { static unsigned long rfkill_no; - struct device *dev = &rfkill->dev; + struct device *dev; int error; - BUG_ON(!rfkill); + if (!rfkill) + return -EINVAL; + + dev = &rfkill->dev; mutex_lock(&rfkill_global_mutex); -- 2.20.1