From: Richard Cochran <richardcochran@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: davem@davemloft.net, jakub.kicinski@netronome.com,
f.fainelli@gmail.com, vivien.didelot@gmail.com, andrew@lunn.ch,
netdev@vger.kernel.org
Subject: Re: [PATCH net 1/2] gianfar: Fix TX timestamping with stacked (DSA and PHY) drivers
Date: Fri, 27 Dec 2019 10:00:11 -0800 [thread overview]
Message-ID: <20191227180011.GF1435@localhost> (raw)
In-Reply-To: <20191227004435.21692-2-olteanv@gmail.com>
On Fri, Dec 27, 2019 at 02:44:34AM +0200, Vladimir Oltean wrote:
> But a stacked driver such as a DSA switch or a PTP-capable PHY can
> also set SKBTX_IN_PROGRESS, which is actually exactly what it should do
> in order to denote that the hardware timestamping process is undergoing.
Please remove the text about the PHY. This driver does not call
skb_tx_timestamp(), and so it isn't possible for a PHY driver to set
the flag.
> There have been discussions [0] as to whether non-MAC drivers need or not to
> set SKBTX_IN_PROGRESS at all (whose purpose is to avoid sending 2
> timestamps, a sw and a hw one, to applications which only expect one).
> But as of this patch, there are at least 2 PTP drivers that would break
> in conjunction with gianfar: the sja1105 DSA switch and the TI PHYTER
> (dp83640).
Again, please drop the bit about the phyter. It is a non-issue here.
The clash with the DSA layer is reason enough for this patch.
> Fixes: f0ee7acfcdd4 ("gianfar: Add hardware TX timestamping support")
> Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
next prev parent reply other threads:[~2019-12-27 18:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 0:44 [PATCH net 0/2] The DSA TX timestamping situation Vladimir Oltean
2019-12-27 0:44 ` [PATCH net 1/2] gianfar: Fix TX timestamping with stacked (DSA and PHY) drivers Vladimir Oltean
2019-12-27 18:00 ` Richard Cochran [this message]
2019-12-27 0:44 ` [PATCH net 2/2] net: dsa: Deny PTP on master if switch supports it Vladimir Oltean
2019-12-27 17:51 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191227180011.GF1435@localhost \
--to=richardcochran@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).