From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BAD0C3276C for ; Thu, 2 Jan 2020 23:32:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F78A217F4 for ; Thu, 2 Jan 2020 23:32:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726219AbgABXcB (ORCPT ); Thu, 2 Jan 2020 18:32:01 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:51886 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726039AbgABXcB (ORCPT ); Thu, 2 Jan 2020 18:32:01 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 82CA5156ED157; Thu, 2 Jan 2020 15:32:00 -0800 (PST) Date: Thu, 02 Jan 2020 15:31:59 -0800 (PST) Message-Id: <20200102.153159.1629304420356427596.davem@davemloft.net> To: andrew@lunn.ch Cc: baruch@tkos.co.il, vivien.didelot@gmail.com, marek.behun@nic.cz, netdev@vger.kernel.org, d.odintsov@traviangames.com Subject: Re: [PATCH] net: dsa: mv88e6xxx: force cmode write on 6141/6341 From: David Miller In-Reply-To: <20200102223641.GI1397@lunn.ch> References: <20200102.124556.1780903980066866154.davem@davemloft.net> <20200102223641.GI1397@lunn.ch> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 02 Jan 2020 15:32:00 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Andrew Lunn Date: Thu, 2 Jan 2020 23:36:41 +0100 > On Thu, Jan 02, 2020 at 12:45:56PM -0800, David Miller wrote: >> From: Baruch Siach >> Date: Thu, 19 Dec 2019 11:48:22 +0200 >> >> > mv88e6xxx_port_set_cmode() relies on cmode stored in struct >> > mv88e6xxx_port to skip cmode update when the requested value matches the >> > cached value. It turns out that mv88e6xxx_port_hidden_write() might >> > change the port cmode setting as a side effect, so we can't rely on the >> > cached value to determine that cmode update in not necessary. >> > >> > Force cmode update in mv88e6341_port_set_cmode(), to make >> > serdes configuration work again. Other mv88e6xxx_port_set_cmode() >> > callers keep the current behaviour. >> > >> > This fixes serdes configuration of the 6141 switch on SolidRun Clearfog >> > GT-8K. >> > >> > Fixes: 7a3007d22e8 ("net: dsa: mv88e6xxx: fully support SERDES on Topaz family") >> > Reported-by: Denis Odintsov >> > Signed-off-by: Baruch Siach >> >> This thread has stalled on December 20th with Baruch asking if we can put this >> in for now as a temporary fix that solves the given problem whilst a better >> long term analysis and change is being worked on. > > Hi David > > It seems like a reasonable fix for the moment. > > Reviewed-by: Andrew Lunn Thanks Andrew. Applied and queued up for -stable.