From: Andrew Lunn <andrew@lunn.ch>
To: David Miller <davem@davemloft.net>
Cc: baruch@tkos.co.il, vivien.didelot@gmail.com, marek.behun@nic.cz,
netdev@vger.kernel.org, d.odintsov@traviangames.com
Subject: Re: [PATCH] net: dsa: mv88e6xxx: force cmode write on 6141/6341
Date: Thu, 2 Jan 2020 23:36:41 +0100 [thread overview]
Message-ID: <20200102223641.GI1397@lunn.ch> (raw)
In-Reply-To: <20200102.124556.1780903980066866154.davem@davemloft.net>
On Thu, Jan 02, 2020 at 12:45:56PM -0800, David Miller wrote:
> From: Baruch Siach <baruch@tkos.co.il>
> Date: Thu, 19 Dec 2019 11:48:22 +0200
>
> > mv88e6xxx_port_set_cmode() relies on cmode stored in struct
> > mv88e6xxx_port to skip cmode update when the requested value matches the
> > cached value. It turns out that mv88e6xxx_port_hidden_write() might
> > change the port cmode setting as a side effect, so we can't rely on the
> > cached value to determine that cmode update in not necessary.
> >
> > Force cmode update in mv88e6341_port_set_cmode(), to make
> > serdes configuration work again. Other mv88e6xxx_port_set_cmode()
> > callers keep the current behaviour.
> >
> > This fixes serdes configuration of the 6141 switch on SolidRun Clearfog
> > GT-8K.
> >
> > Fixes: 7a3007d22e8 ("net: dsa: mv88e6xxx: fully support SERDES on Topaz family")
> > Reported-by: Denis Odintsov <d.odintsov@traviangames.com>
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>
> This thread has stalled on December 20th with Baruch asking if we can put this
> in for now as a temporary fix that solves the given problem whilst a better
> long term analysis and change is being worked on.
Hi David
It seems like a reasonable fix for the moment.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2020-01-02 22:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 9:48 [PATCH] net: dsa: mv88e6xxx: force cmode write on 6141/6341 Baruch Siach
2019-12-20 19:27 ` Vivien Didelot
2019-12-21 10:22 ` Andrew Lunn
2019-12-21 21:51 ` Vivien Didelot
2019-12-22 9:43 ` Baruch Siach
2020-01-02 20:45 ` David Miller
2020-01-02 22:36 ` Andrew Lunn [this message]
2020-01-02 23:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200102223641.GI1397@lunn.ch \
--to=andrew@lunn.ch \
--cc=baruch@tkos.co.il \
--cc=d.odintsov@traviangames.com \
--cc=davem@davemloft.net \
--cc=marek.behun@nic.cz \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).