From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0E87C00523 for ; Fri, 3 Jan 2020 08:01:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95670222C3 for ; Fri, 3 Jan 2020 08:01:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="o7qsgNXc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727146AbgACIBs (ORCPT ); Fri, 3 Jan 2020 03:01:48 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:40850 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725890AbgACIBs (ORCPT ); Fri, 3 Jan 2020 03:01:48 -0500 Received: by mail-wr1-f65.google.com with SMTP id c14so41566475wrn.7 for ; Fri, 03 Jan 2020 00:01:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wU0TvupZ5BJU9ETN87LE6rZxtzRHnVPyyKAP6+wDyhU=; b=o7qsgNXcDU696J7nLRgPax/ERGxBHjC+k0WCNKU4RRBs6nPDL3fapYBhHnuHwYzR2Z u3Z1OrLQCN7dZHCIfTDKiKOiz6Of7FqcmxTYW6K8eUhoqmzJizeLd6/TlYM0O4sn1JT4 1L9iN607Dj4Pioq0TT2F+io2LDVEE9VuWPPdgkU5SFWXbmsQNnKXlb5cozjsZcx3FNxh kO1J1C3K7JKV6rZgIoSHlS7tvotAREcPQhC97zpXCbzA2d/L+yGVOAvwvYTXOCJV4Rev iAnuJnFbgBeJHwUdcE0m6nMPFQbe9MaIoGoSs2JtLEArEbQuwforPrS3LZVRHob0Qtyr H+Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wU0TvupZ5BJU9ETN87LE6rZxtzRHnVPyyKAP6+wDyhU=; b=GUJaKge1y+IiLmLh9V5ocHpzTnOieW14l2xMvh8RJIRuQUudeWoQncYh8+UkU8evQf FsxvrrbWzTCC6BIWSV5LI2RB0GfqONdaZ1DCzuyFNrwffCKjz3pix4sDc0qLMDsohH2r d1vnVsFsScA9eEQrZ1poWe0jpuBAMwWrfcHie5pp+yuHhjmM0m71qxQlTl1uCdo/NNUI dR8lRuZvVIngyhSHfrUeIFn4RwrUDl6AJ6DvYacpCmyIdX/WXBdHDc7V8BbzVMo6qCpr HWlSsZWVDwaE8WAIqhGVdgsosCkGSsfrpA+Vyx2qkoAskPPT2X5Zyk+SI4kouBIjCTlX HHPQ== X-Gm-Message-State: APjAAAVCva/9H2eH3jDupGGTo/UXKoiEPk7GSHogcJplUdr6gJq4iriJ 1hUjIm5P+wdV3y2+oLaOal14IWALndM= X-Google-Smtp-Source: APXvYqwZJsA0NgVJMGEx09Vlphl40as8tcL015upc4gHE/2zsQl258HowzcLyxnQqModvnS27iQkuw== X-Received: by 2002:a5d:540f:: with SMTP id g15mr83428682wrv.86.1578038506041; Fri, 03 Jan 2020 00:01:46 -0800 (PST) Received: from netronome.com ([2001:982:756:703:d63d:7eff:fe99:ac9d]) by smtp.gmail.com with ESMTPSA id j2sm11450736wmk.23.2020.01.03.00.01.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2020 00:01:45 -0800 (PST) Date: Fri, 3 Jan 2020 09:01:45 +0100 From: Simon Horman To: David Miller Cc: netdev@vger.kernel.org Subject: Re: [PATCH] net: Correct type of tcp_syncookies sysctl. Message-ID: <20200103080144.GC12930@netronome.com> References: <20200102.160818.1273976528943190177.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200102.160818.1273976528943190177.davem@davemloft.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jan 02, 2020 at 04:08:18PM -0800, David Miller wrote: > > It can take on the values of '0', '1', and '2' and thus > is not a boolean. > > Signed-off-by: David S. Miller Reviewed-by: Simon Horman > --- > Documentation/networking/ip-sysctl.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Applied and pushed out to 'net'. > > diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt > index fd26788e8c96..48ccb1b31160 100644 > --- a/Documentation/networking/ip-sysctl.txt > +++ b/Documentation/networking/ip-sysctl.txt > @@ -603,7 +603,7 @@ tcp_synack_retries - INTEGER > with the current initial RTO of 1second. With this the final timeout > for a passive TCP connection will happen after 63seconds. > > -tcp_syncookies - BOOLEAN > +tcp_syncookies - INTEGER > Only valid when the kernel was compiled with CONFIG_SYN_COOKIES > Send out syncookies when the syn backlog queue of a socket > overflows. This is to prevent against the common 'SYN flood attack' > -- > 2.20.1 >