* [PATCH] net: netsec: Change page pool nid to NUMA_NO_NODE
@ 2020-01-03 11:40 Ilias Apalodimas
2020-01-03 12:50 ` Jesper Dangaard Brouer
2020-01-03 20:28 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Ilias Apalodimas @ 2020-01-03 11:40 UTC (permalink / raw)
To: netdev, jaswinder.singh, davem, brouer, lorenzo; +Cc: Ilias Apalodimas
The current driver only exists on a non NUMA aware machine.
With 44768decb7c0 ("page_pool: handle page recycle for NUMA_NO_NODE condition")
applied we can safely change that to NUMA_NO_NODE and accommodate future
NUMA aware hardware using netsec network interface
Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
drivers/net/ethernet/socionext/netsec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
index 869a498e3b5e..b5a9e947a4a8 100644
--- a/drivers/net/ethernet/socionext/netsec.c
+++ b/drivers/net/ethernet/socionext/netsec.c
@@ -1279,7 +1279,7 @@ static int netsec_setup_rx_dring(struct netsec_priv *priv)
/* internal DMA mapping in page_pool */
pp_params.flags = PP_FLAG_DMA_MAP;
pp_params.pool_size = DESC_NUM;
- pp_params.nid = cpu_to_node(0);
+ pp_params.nid = NUMA_NO_NODE;
pp_params.dev = priv->dev;
pp_params.dma_dir = xdp_prog ? DMA_BIDIRECTIONAL : DMA_FROM_DEVICE;
--
2.25.0.rc0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: netsec: Change page pool nid to NUMA_NO_NODE
2020-01-03 11:40 [PATCH] net: netsec: Change page pool nid to NUMA_NO_NODE Ilias Apalodimas
@ 2020-01-03 12:50 ` Jesper Dangaard Brouer
2020-01-03 20:28 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jesper Dangaard Brouer @ 2020-01-03 12:50 UTC (permalink / raw)
To: Ilias Apalodimas; +Cc: brouer, netdev, jaswinder.singh, davem, lorenzo
On Fri, 3 Jan 2020 13:40:32 +0200
Ilias Apalodimas <ilias.apalodimas@linaro.org> wrote:
> The current driver only exists on a non NUMA aware machine.
> With 44768decb7c0 ("page_pool: handle page recycle for NUMA_NO_NODE condition")
> applied we can safely change that to NUMA_NO_NODE and accommodate future
> NUMA aware hardware using netsec network interface
>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: netsec: Change page pool nid to NUMA_NO_NODE
2020-01-03 11:40 [PATCH] net: netsec: Change page pool nid to NUMA_NO_NODE Ilias Apalodimas
2020-01-03 12:50 ` Jesper Dangaard Brouer
@ 2020-01-03 20:28 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-01-03 20:28 UTC (permalink / raw)
To: ilias.apalodimas; +Cc: netdev, jaswinder.singh, brouer, lorenzo
From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Date: Fri, 3 Jan 2020 13:40:32 +0200
> The current driver only exists on a non NUMA aware machine.
> With 44768decb7c0 ("page_pool: handle page recycle for NUMA_NO_NODE condition")
> applied we can safely change that to NUMA_NO_NODE and accommodate future
> NUMA aware hardware using netsec network interface
>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Applied, but please make it clear that this targets the net-next
tree in the future by stating "[PATCH net-next]" in your Subject
lines.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-03 20:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-03 11:40 [PATCH] net: netsec: Change page pool nid to NUMA_NO_NODE Ilias Apalodimas
2020-01-03 12:50 ` Jesper Dangaard Brouer
2020-01-03 20:28 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).