From: Andrew Lunn <andrew@lunn.ch>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH net] net: phylink: fix failure to register on x86 systems
Date: Fri, 3 Jan 2020 21:25:57 +0100 [thread overview]
Message-ID: <20200103202557.GR1397@lunn.ch> (raw)
In-Reply-To: <E1inOeC-00004q-18@rmk-PC.armlinux.org.uk>
On Fri, Jan 03, 2020 at 03:13:56PM +0000, Russell King wrote:
> The kernel test robot reports a boot failure with qemu in 5.5-rc,
> referencing commit 2203cbf2c8b5 ("net: sfp: move fwnode parsing into
> sfp-bus layer"). This is caused by phylink_create() being passed a
> NULL fwnode, causing fwnode_property_get_reference_args() to return
> -EINVAL.
>
> Don't attempt to attach to a SFP bus if we have no fwnode, which
> avoids this issue.
>
> Reported-by: kernel test robot <rong.a.chen@intel.com>
> Fixes: 2203cbf2c8b5 ("net: sfp: move fwnode parsing into sfp-bus layer")
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2020-01-03 20:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 15:13 [PATCH net] net: phylink: fix failure to register on x86 systems Russell King
2020-01-03 18:45 ` Florian Fainelli
2020-01-03 20:25 ` Andrew Lunn [this message]
2020-01-03 20:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103202557.GR1397@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).