* [PATCH net] net: phylink: fix failure to register on x86 systems
@ 2020-01-03 15:13 Russell King
2020-01-03 18:45 ` Florian Fainelli
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Russell King @ 2020-01-03 15:13 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Heiner Kallweit; +Cc: David S. Miller, netdev
The kernel test robot reports a boot failure with qemu in 5.5-rc,
referencing commit 2203cbf2c8b5 ("net: sfp: move fwnode parsing into
sfp-bus layer"). This is caused by phylink_create() being passed a
NULL fwnode, causing fwnode_property_get_reference_args() to return
-EINVAL.
Don't attempt to attach to a SFP bus if we have no fwnode, which
avoids this issue.
Reported-by: kernel test robot <rong.a.chen@intel.com>
Fixes: 2203cbf2c8b5 ("net: sfp: move fwnode parsing into sfp-bus layer")
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
drivers/net/phy/phylink.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index c0be51baf827..dcab9061b1ce 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -562,6 +562,9 @@ static int phylink_register_sfp(struct phylink *pl,
struct sfp_bus *bus;
int ret;
+ if (!fwnode)
+ return 0;
+
bus = sfp_bus_find_fwnode(fwnode);
if (IS_ERR(bus)) {
ret = PTR_ERR(bus);
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net] net: phylink: fix failure to register on x86 systems
2020-01-03 15:13 [PATCH net] net: phylink: fix failure to register on x86 systems Russell King
@ 2020-01-03 18:45 ` Florian Fainelli
2020-01-03 20:25 ` Andrew Lunn
2020-01-03 20:38 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2020-01-03 18:45 UTC (permalink / raw)
To: Russell King, Andrew Lunn, Heiner Kallweit; +Cc: David S. Miller, netdev
On 1/3/20 7:13 AM, Russell King wrote:
> The kernel test robot reports a boot failure with qemu in 5.5-rc,
> referencing commit 2203cbf2c8b5 ("net: sfp: move fwnode parsing into
> sfp-bus layer"). This is caused by phylink_create() being passed a
> NULL fwnode, causing fwnode_property_get_reference_args() to return
> -EINVAL.
>
> Don't attempt to attach to a SFP bus if we have no fwnode, which
> avoids this issue.
>
> Reported-by: kernel test robot <rong.a.chen@intel.com>
> Fixes: 2203cbf2c8b5 ("net: sfp: move fwnode parsing into sfp-bus layer")
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] net: phylink: fix failure to register on x86 systems
2020-01-03 15:13 [PATCH net] net: phylink: fix failure to register on x86 systems Russell King
2020-01-03 18:45 ` Florian Fainelli
@ 2020-01-03 20:25 ` Andrew Lunn
2020-01-03 20:38 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2020-01-03 20:25 UTC (permalink / raw)
To: Russell King; +Cc: Florian Fainelli, Heiner Kallweit, David S. Miller, netdev
On Fri, Jan 03, 2020 at 03:13:56PM +0000, Russell King wrote:
> The kernel test robot reports a boot failure with qemu in 5.5-rc,
> referencing commit 2203cbf2c8b5 ("net: sfp: move fwnode parsing into
> sfp-bus layer"). This is caused by phylink_create() being passed a
> NULL fwnode, causing fwnode_property_get_reference_args() to return
> -EINVAL.
>
> Don't attempt to attach to a SFP bus if we have no fwnode, which
> avoids this issue.
>
> Reported-by: kernel test robot <rong.a.chen@intel.com>
> Fixes: 2203cbf2c8b5 ("net: sfp: move fwnode parsing into sfp-bus layer")
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] net: phylink: fix failure to register on x86 systems
2020-01-03 15:13 [PATCH net] net: phylink: fix failure to register on x86 systems Russell King
2020-01-03 18:45 ` Florian Fainelli
2020-01-03 20:25 ` Andrew Lunn
@ 2020-01-03 20:38 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-01-03 20:38 UTC (permalink / raw)
To: rmk+kernel; +Cc: andrew, f.fainelli, hkallweit1, netdev
From: Russell King <rmk+kernel@armlinux.org.uk>
Date: Fri, 03 Jan 2020 15:13:56 +0000
> The kernel test robot reports a boot failure with qemu in 5.5-rc,
> referencing commit 2203cbf2c8b5 ("net: sfp: move fwnode parsing into
> sfp-bus layer"). This is caused by phylink_create() being passed a
> NULL fwnode, causing fwnode_property_get_reference_args() to return
> -EINVAL.
>
> Don't attempt to attach to a SFP bus if we have no fwnode, which
> avoids this issue.
>
> Reported-by: kernel test robot <rong.a.chen@intel.com>
> Fixes: 2203cbf2c8b5 ("net: sfp: move fwnode parsing into sfp-bus layer")
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Applied, thanks Russell.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-03 20:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-03 15:13 [PATCH net] net: phylink: fix failure to register on x86 systems Russell King
2020-01-03 18:45 ` Florian Fainelli
2020-01-03 20:25 ` Andrew Lunn
2020-01-03 20:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).