Re: [PATCH bpf-next 2/6] libbpf: Collect static vs global info about functions

Song Liu
2020-01-08T17:58:44Z

> On Jan 8, 2020, at 2:25 AM, Toke Høiland-Jørgensen <toke@redhat.com> wrote:
>
> Alexei Starovoitov <ast@kernel.org> writes:
>
>> Collect static vs global information about BPF functions from ELF file and
>> improve BTF with this additional info if llvm is too old and doesn't emit it on
>> its own.
>
> Has the support for this actually landed in LLVM yet? I tried grep'ing
> in the commit log and couldn't find anything...
>
> [...]
>> @@ -313,6 +321,7 @@ struct bpf_object {
>> bool loaded;
>> bool has_pseudo_calls;
>> bool relaxed_core_relocs;
>> + bool llvm_emits_func_linkage;
>
> Nit: s/llvm/compiler/? Presumably GCC will also support this at some
> point?

Echoing this nit (and other references to llvm). Otherwise,

Acked-by: Song Liu <songliubraving@fb.com>