Re: [PATCH bpf-next 2/6] libbpf: Collect static vs global info about functions

Yonghong Song
2020-01-08T16:25:45Z

On 1/8/20 2:25 AM, Toke Høiland-Jørgensen wrote:
> Alexei Starovoitov <ast@kernel.org> writes:
>
>> Collect static vs global information about BPF functions from ELF file and
>> improve BTF with this additional info if llvm is too old and doesn't emit it on
>> its own.
>
> Has the support for this actually landed in LLVM yet? I tried grep'ing
> in the commit log and couldn't find anything...

It has not landed yet. The commit link is:
https://reviews.llvm.org/D71638

I will try to land the patch in the next couple of days once this series
of patch is merged or the principle of the patch is accepted.

>
> [...]
>> @@ -313,6 +321,7 @@ struct bpf_object {
>> bool loaded;
>> bool has_pseudo_calls;
>> bool relaxed_core_relocs;
>> + bool llvm_emits_func_linkage;
>
> Nit: s/llvm/compiler/? Presumably GCC will also support this at some
> point?
>
> -Toke
>