From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+46a4ad33f345d1dd346e@syzkaller.appspotmail.com
Subject: Re: [PATCH nf] netfilter: conntrack: dccp, sctp: handle null timeout argument
Date: Wed, 8 Jan 2020 23:32:14 +0100 [thread overview]
Message-ID: <20200108223214.3niyo2o2sr2zf3fg@salvia> (raw)
In-Reply-To: <20200106223417.18279-1-fw@strlen.de>
On Mon, Jan 06, 2020 at 11:34:17PM +0100, Florian Westphal wrote:
> The timeout pointer can be NULL which means we should modify the
> per-nets timeout instead.
>
> All do this, except sctp and dccp which instead give:
>
> general protection fault: 0000 [#1] PREEMPT SMP KASAN
> net/netfilter/nf_conntrack_proto_dccp.c:682
> ctnl_timeout_parse_policy+0x150/0x1d0 net/netfilter/nfnetlink_cttimeout.c:67
> cttimeout_default_set+0x150/0x1c0 net/netfilter/nfnetlink_cttimeout.c:368
> nfnetlink_rcv_msg+0xcf2/0xfb0 net/netfilter/nfnetlink.c:229
> netlink_rcv_skb+0x177/0x450 net/netlink/af_netlink.c:2477
Applied, thanks Florian.
next prev parent reply other threads:[~2020-01-08 22:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 20:44 general protection fault in dccp_timeout_nlattr_to_obj syzbot
2020-01-06 22:34 ` [PATCH nf] netfilter: conntrack: dccp, sctp: handle null timeout argument Florian Westphal
2020-01-08 22:32 ` Pablo Neira Ayuso [this message]
2020-01-07 1:28 ` general protection fault in dccp_timeout_nlattr_to_obj syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108223214.3niyo2o2sr2zf3fg@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=syzbot+46a4ad33f345d1dd346e@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox