From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70E67C32771 for ; Thu, 9 Jan 2020 08:26:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DD2420673 for ; Thu, 9 Jan 2020 08:26:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="K4P4KVoO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728407AbgAII0u (ORCPT ); Thu, 9 Jan 2020 03:26:50 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:47429 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728347AbgAII0u (ORCPT ); Thu, 9 Jan 2020 03:26:50 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id C6F7F21CDA; Thu, 9 Jan 2020 03:26:48 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 09 Jan 2020 03:26:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=8xSNRZ KbiFnlwHQpyfLhNCmhDc50M+zIr3Dzt6d7M34=; b=K4P4KVoOqqooVDCabWeQAd IVUHo+sDgvT9C/zVDsAM23kNqzFI6io59woSYIaLdKFO4EdHjIXkgXA+et3efYOG LjyMK4u7WOlx0OmK1i2bGcVl6qOwUGhrhJ8ZmGZ1dNOZHs8FNuUuGBmb9H4NkxOe NDudRRRHI4wf85+Du2pSXUxSuWAy4qavGIo5XPtXn+atZDzOXhwY1nZj4ePVNsvV eBtAR0YvKYAvOw1jZiEPEU7qIgUjzK9gqmY0Lhbc3b6u9htx/OxmK4wYWhUfpfuw /pU2H+RlSb8CRUlcIpz8vBDFcgievY4kTOyqJEFmG1fBUqIhMf7x/ztExwlCVcaQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdehledgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcu ufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecukfhppedule efrdegjedrudeihedrvdehudenucfrrghrrghmpehmrghilhhfrhhomhepihguohhstghh sehiughoshgthhdrohhrghenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (unknown [193.47.165.251]) by mail.messagingengine.com (Postfix) with ESMTPA id 19E5280059; Thu, 9 Jan 2020 03:26:47 -0500 (EST) Date: Thu, 9 Jan 2020 10:26:46 +0200 From: Ido Schimmel To: David Ahern Cc: netdev@vger.kernel.org, davem@davemloft.net, jiri@mellanox.com, jakub.kicinski@netronome.com, roopa@cumulusnetworks.com, mlxsw@mellanox.com, Ido Schimmel Subject: Re: [PATCH net-next 02/10] ipv4: Encapsulate function arguments in a struct Message-ID: <20200109082646.GA273688@splinter> References: <20200107154517.239665-1-idosch@idosch.org> <20200107154517.239665-3-idosch@idosch.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 08, 2020 at 11:37:28AM -0700, David Ahern wrote: > On 1/7/20 8:45 AM, Ido Schimmel wrote: > > diff --git a/net/ipv4/fib_lookup.h b/net/ipv4/fib_lookup.h > > index a68b5e21ec51..b34594a9965f 100644 > > --- a/net/ipv4/fib_lookup.h > > +++ b/net/ipv4/fib_lookup.h > > @@ -21,6 +21,15 @@ struct fib_alias { > > > > #define FA_S_ACCESSED 0x01 > > > > +struct fib_rt_info { > > + struct fib_info *fi; > > + u32 tb_id; > > + __be32 dst; > > + int dst_len; > > + u8 tos; > > + u8 type; > > +}; > > + > > /* Dont write on fa_state unless needed, to keep it shared on all cpus */ > > static inline void fib_alias_accessed(struct fib_alias *fa) > > { > > @@ -35,9 +44,8 @@ struct fib_info *fib_create_info(struct fib_config *cfg, > > int fib_nh_match(struct fib_config *cfg, struct fib_info *fi, > > struct netlink_ext_ack *extack); > > bool fib_metrics_match(struct fib_config *cfg, struct fib_info *fi); > > -int fib_dump_info(struct sk_buff *skb, u32 pid, u32 seq, int event, u32 tb_id, > > - u8 type, __be32 dst, int dst_len, u8 tos, struct fib_info *fi, > > - unsigned int); > > +int fib_dump_info(struct sk_buff *skb, u32 pid, u32 seq, int event, > > + struct fib_rt_info *fri, unsigned int); > > since you are modifying this, can you add a name for that last argument? Yes, will add in v2 > > > Otherwise, nice cleanup. > > Reviewed-by: David Ahern Thanks!