From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93007C33CA4 for ; Fri, 10 Jan 2020 14:59:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6423920721 for ; Fri, 10 Jan 2020 14:59:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="VSQn0Ttt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728341AbgAJO7I (ORCPT ); Fri, 10 Jan 2020 09:59:08 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:42890 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727892AbgAJO7I (ORCPT ); Fri, 10 Jan 2020 09:59:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=KcB+0FZvEwMSZ71K+kCoZ9X5u6DRQpvD2AQdpGnKqKU=; b=VSQn0TttzYKM/CdTWxnCb9SAK 98MKbpP1VXCI0Wb/ur9FQV6efmKh98+5V8KPBvOrOfxB7IrgR05Ta3vlsVkBS618/wkR/PkF8y4f3 9rX0rXKOOIac1MIFCacPThgaz4YTylyoGIYqIOzwsN7VjtDB57lpecTA+jJoaRUPUpmBVqjLnuepN yP+TmIC7pPvUW5xAl5K7439M3ROyOI9TB3VDgrofXb84No5s41VboEGKCVgNbHnOSADnNtsrbQ4TV CHjv74Fj6rjhDsWFYY47kXdsbHAN3nkCSjgGVFDIUhyo8I+KhX8UEtmC0LtaI/D1YDzXTd8TXOgSC tbRk2znsQ==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:53122) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ipvkU-0003i1-OE; Fri, 10 Jan 2020 14:58:54 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1ipvkP-0001aZ-ER; Fri, 10 Jan 2020 14:58:49 +0000 Date: Fri, 10 Jan 2020 14:58:49 +0000 From: Russell King - ARM Linux admin To: Andre Przywara Cc: "David S . Miller" , Radhey Shyam Pandey , Robert Hancock , netdev@vger.kernel.org, Michal Simek , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/14] net: axienet: Fix SGMII support Message-ID: <20200110145849.GC25745@shell.armlinux.org.uk> References: <20200110115415.75683-1-andre.przywara@arm.com> <20200110115415.75683-8-andre.przywara@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200110115415.75683-8-andre.przywara@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jan 10, 2020 at 11:54:08AM +0000, Andre Przywara wrote: > With SGMII, the MAC and the PHY can negotiate the link speed between > themselves, without the host needing to mediate between them. > Linux recognises this, and will call phylink's mac_config with the speed > member set to SPEED_UNKNOWN (-1). I wonder whether you have read the documentation for the phylink mac_config() method (if not, please read it, it contains some very important information about what mac_config() should do.) When operating in SGMII in-band mode, state->speed and state->duplex are not actually valid. You'll probably want to submit a better patch after reading the documentation. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up