From: Jakub Kicinski <kubakici@wp.pl>
To: <ecree@solarflare.com>, <amaftei@solarflare.com>
Cc: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>,
<linux-net-drivers@solarflare.com>, <davem@davemloft.net>,
<mhabets@solarflare.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] sfc/ethtool_common: Make some function to static
Date: Mon, 13 Jan 2020 04:58:46 -0800 [thread overview]
Message-ID: <20200113045846.3330b57c@cakuba> (raw)
In-Reply-To: <20200113112411.28090-1-zhangxiaoxu5@huawei.com>
On Mon, 13 Jan 2020 19:24:11 +0800, Zhang Xiaoxu wrote:
> Fix sparse warning:
>
> drivers/net/ethernet/sfc/ethtool_common.c
> warning: symbol 'efx_fill_test' was not declared. Should it be static?
> warning: symbol 'efx_fill_loopback_test' was not declared.
> Should it be static?
> warning: symbol 'efx_describe_per_queue_stats' was not declared.
> Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Ed, Alex, since you were talking about reusing this code would you
rather add a declaration for these function to a header? Or should
I apply the current fix?
next prev parent reply other threads:[~2020-01-13 12:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 11:24 [PATCH] sfc/ethtool_common: Make some function to static Zhang Xiaoxu
2020-01-13 12:58 ` Jakub Kicinski [this message]
2020-01-13 13:29 ` Martin Habets
2020-01-13 14:03 ` Jakub Kicinski
2020-01-13 13:29 ` Martin Habets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113045846.3330b57c@cakuba \
--to=kubakici@wp.pl \
--cc=amaftei@solarflare.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=mhabets@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).