From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93148C33CAD for ; Mon, 13 Jan 2020 12:58:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 570DD207FF for ; Mon, 13 Jan 2020 12:58:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=wp.pl header.i=@wp.pl header.b="QfQdImP2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727222AbgAMM65 (ORCPT ); Mon, 13 Jan 2020 07:58:57 -0500 Received: from mx4.wp.pl ([212.77.101.11]:7257 "EHLO mx4.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726523AbgAMM65 (ORCPT ); Mon, 13 Jan 2020 07:58:57 -0500 Received: (wp-smtpd smtp.wp.pl 28385 invoked from network); 13 Jan 2020 13:58:54 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1578920335; bh=SR3kC/ZoSfEBGgeqzp09eP+AkVVtPZC7aWzLpCxtZM0=; h=From:To:Cc:Subject; b=QfQdImP21gyKRCG//341cm/ZgENmkme62gjtUIGpzGceIcDjsJmjLO9AGOMLreTpD AM/8rfGXEa+C9KIfxp42RhP1aHM/eji3YErUrKphmR6gHfbWZ8ze00IENL8rSLlKkv EktpexUna4Fhq6PUVcVciYlolO6z7kmNcRjtzjRM= Received: from c-73-93-4-247.hsd1.ca.comcast.net (HELO cakuba) (kubakici@wp.pl@[73.93.4.247]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 13 Jan 2020 13:58:54 +0100 Date: Mon, 13 Jan 2020 04:58:46 -0800 From: Jakub Kicinski To: , Cc: Zhang Xiaoxu , , , , Subject: Re: [PATCH] sfc/ethtool_common: Make some function to static Message-ID: <20200113045846.3330b57c@cakuba> In-Reply-To: <20200113112411.28090-1-zhangxiaoxu5@huawei.com> References: <20200113112411.28090-1-zhangxiaoxu5@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: a69f63854e16864fac017bd07ac364e2 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 000000A [IaM0] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 13 Jan 2020 19:24:11 +0800, Zhang Xiaoxu wrote: > Fix sparse warning: > > drivers/net/ethernet/sfc/ethtool_common.c > warning: symbol 'efx_fill_test' was not declared. Should it be static? > warning: symbol 'efx_fill_loopback_test' was not declared. > Should it be static? > warning: symbol 'efx_describe_per_queue_stats' was not declared. > Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: Zhang Xiaoxu Ed, Alex, since you were talking about reusing this code would you rather add a declaration for these function to a header? Or should I apply the current fix?