From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02227C33CA9 for ; Mon, 13 Jan 2020 15:20:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA83821569 for ; Mon, 13 Jan 2020 15:20:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=wp.pl header.i=@wp.pl header.b="NeSFLFdi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728918AbgAMPUR (ORCPT ); Mon, 13 Jan 2020 10:20:17 -0500 Received: from mx4.wp.pl ([212.77.101.12]:21486 "EHLO mx4.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726567AbgAMPUQ (ORCPT ); Mon, 13 Jan 2020 10:20:16 -0500 Received: (wp-smtpd smtp.wp.pl 25356 invoked from network); 13 Jan 2020 16:20:13 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1578928814; bh=ckiIUgf+Tu5dz5bSkyhu+9/WG8U3ri+CC3Yzi1RogcU=; h=From:To:Cc:Subject; b=NeSFLFdiaaOtnduuiNXv0m3FxynzuH3vJW9Ys2S+vbRzGA0LVmL0946RrA6kxb4KH +VLCkHAyV57L9+KK16iXno0hhZnd//0dphpVH4rQMsgypOHg3029TTgu6CasCN+Hs3 jcUW6qwhui9F5L0Bn2LzwrHrTHCsdDI4zJyAPdvI= Received: from unknown (HELO cakuba) (kubakici@wp.pl@[172.58.35.234]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 13 Jan 2020 16:20:13 +0100 Date: Mon, 13 Jan 2020 07:19:46 -0800 From: Jakub Kicinski To: Jose Abreu Cc: netdev@vger.kernel.org, Joao Pinto , Giuseppe Cavallaro , Alexandre Torgue , "David S. Miller" , Maxime Coquelin , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 6/8] net: stmmac: Add missing information in DebugFS capabilities file Message-ID: <20200113071946.1dbdecd1@cakuba> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: e9542c228b230751ee00c2b6f941528f X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000000 [gaNR] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 13 Jan 2020 14:02:41 +0100, Jose Abreu wrote: > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index fcc1ffe0b11e..7c2645ee81b1 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -4341,6 +4341,10 @@ static int stmmac_dma_cap_show(struct seq_file *seq, void *v) > priv->dma_cap.number_rx_queues); > seq_printf(seq, "\tNumber of Additional TX queues: %d\n", > priv->dma_cap.number_tx_queues); > + seq_printf(seq, "\tCurrent number of TX queues: %d\n", > + priv->plat->tx_queues_to_use); > + seq_printf(seq, "\tCurrent number of RX queues: %d\n", > + priv->plat->rx_queues_to_use); You should probably just implement ethtool get_channels. nack on this part. > seq_printf(seq, "\tEnhanced descriptors: %s\n", > (priv->dma_cap.enh_desc) ? "Y" : "N"); > seq_printf(seq, "\tTX Fifo Size: %d\n", priv->dma_cap.tx_fifo_size);