* [PATCH net-next] ptr_ring: add include of linux/mm.h
@ 2020-01-13 10:22 Jesper Dangaard Brouer
2020-01-13 13:16 ` Michael S. Tsirkin
2020-01-14 2:19 ` Jakub Kicinski
0 siblings, 2 replies; 3+ messages in thread
From: Jesper Dangaard Brouer @ 2020-01-13 10:22 UTC (permalink / raw)
Cc: Jesper Dangaard Brouer, netdev, David S. Miller,
Michael S. Tsirkin, Jason Wang
Commit 0bf7800f1799 ("ptr_ring: try vmalloc() when kmalloc() fails")
started to use kvmalloc_array and kvfree, which are defined in mm.h,
the previous functions kcalloc and kfree, which are defined in slab.h.
Add the missing include of linux/mm.h. This went unnoticed as other
include files happened to include mm.h.
Fixes: 0bf7800f1799 ("ptr_ring: try vmalloc() when kmalloc() fails")
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
---
include/linux/ptr_ring.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/ptr_ring.h b/include/linux/ptr_ring.h
index 0abe9a4fc842..417db0a79a62 100644
--- a/include/linux/ptr_ring.h
+++ b/include/linux/ptr_ring.h
@@ -23,6 +23,7 @@
#include <linux/types.h>
#include <linux/compiler.h>
#include <linux/slab.h>
+#include <linux/mm.h>
#include <asm/errno.h>
#endif
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] ptr_ring: add include of linux/mm.h
2020-01-13 10:22 [PATCH net-next] ptr_ring: add include of linux/mm.h Jesper Dangaard Brouer
@ 2020-01-13 13:16 ` Michael S. Tsirkin
2020-01-14 2:19 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2020-01-13 13:16 UTC (permalink / raw)
To: Jesper Dangaard Brouer; +Cc: netdev, David S. Miller, Jason Wang
On Mon, Jan 13, 2020 at 11:22:16AM +0100, Jesper Dangaard Brouer wrote:
> Commit 0bf7800f1799 ("ptr_ring: try vmalloc() when kmalloc() fails")
> started to use kvmalloc_array and kvfree, which are defined in mm.h,
> the previous functions kcalloc and kfree, which are defined in slab.h.
>
> Add the missing include of linux/mm.h. This went unnoticed as other
> include files happened to include mm.h.
>
> Fixes: 0bf7800f1799 ("ptr_ring: try vmalloc() when kmalloc() fails")
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/linux/ptr_ring.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/ptr_ring.h b/include/linux/ptr_ring.h
> index 0abe9a4fc842..417db0a79a62 100644
> --- a/include/linux/ptr_ring.h
> +++ b/include/linux/ptr_ring.h
> @@ -23,6 +23,7 @@
> #include <linux/types.h>
> #include <linux/compiler.h>
> #include <linux/slab.h>
> +#include <linux/mm.h>
> #include <asm/errno.h>
> #endif
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] ptr_ring: add include of linux/mm.h
2020-01-13 10:22 [PATCH net-next] ptr_ring: add include of linux/mm.h Jesper Dangaard Brouer
2020-01-13 13:16 ` Michael S. Tsirkin
@ 2020-01-14 2:19 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2020-01-14 2:19 UTC (permalink / raw)
To: Jesper Dangaard Brouer
Cc: netdev, David S. Miller, Michael S. Tsirkin, Jason Wang
On Mon, 13 Jan 2020 11:22:16 +0100, Jesper Dangaard Brouer wrote:
> Commit 0bf7800f1799 ("ptr_ring: try vmalloc() when kmalloc() fails")
> started to use kvmalloc_array and kvfree, which are defined in mm.h,
> the previous functions kcalloc and kfree, which are defined in slab.h.
>
> Add the missing include of linux/mm.h. This went unnoticed as other
> include files happened to include mm.h.
>
> Fixes: 0bf7800f1799 ("ptr_ring: try vmalloc() when kmalloc() fails")
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Applied to net-next as specified, let's see if bots pull it into stable
for no good reason :) Thank you!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-14 2:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-13 10:22 [PATCH net-next] ptr_ring: add include of linux/mm.h Jesper Dangaard Brouer
2020-01-13 13:16 ` Michael S. Tsirkin
2020-01-14 2:19 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).