From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AF88C32771 for ; Wed, 15 Jan 2020 20:11:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA79C22522 for ; Wed, 15 Jan 2020 20:11:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="oBJCRmXV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729878AbgAOULW (ORCPT ); Wed, 15 Jan 2020 15:11:22 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:43833 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729442AbgAOULV (ORCPT ); Wed, 15 Jan 2020 15:11:21 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id C96082222E; Wed, 15 Jan 2020 15:11:20 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 15 Jan 2020 15:11:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Hrs1us qs1mtZ1S12sxOORgd0r1wdct91FnDUKvIj+nA=; b=oBJCRmXV7YFh7UlTwB6juf Bb7NR+V7mgrTH6kghUygG6NQFxtmwzBKw2sppG/hUVCskw9ltutxvPLt38MOp6wa I29A1GIf6x8Y9myDqjnO7AqilgRllGrR7qH8Y9JEVgNivxUvQaeVxJJaruAry2QX T70M/w6YsjPd2AyMMD43EI7kJt0YcU23dDvMHC83CbUpLReThIsJtzoUBMzhUpVb Yapt1psci4+463nQqOtRbj8x/XVRRbtaF08VOaSVHz6zRogwYexsPJATfTZpJ6CW 42MDECNDynlo8SbEtCMy0Q7bLYvGbLBYmkZ/TwhQax+qh0E7t5RLLII8039X/uqQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrtdefgddufedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefkughoucfu tghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrdhorhhgqeenucfkphepjeejrd dufeekrddvgeelrddvtdelnecurfgrrhgrmhepmhgrihhlfhhrohhmpehiughoshgthhes ihguohhstghhrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (unknown [77.138.249.209]) by mail.messagingengine.com (Postfix) with ESMTPA id 17E3C30600A8; Wed, 15 Jan 2020 15:11:19 -0500 (EST) Date: Wed, 15 Jan 2020 22:11:07 +0200 From: Ido Schimmel To: Eric Dumazet Cc: "David S . Miller" , netdev , Eric Dumazet , syzbot , Ido Schimmel Subject: Re: [PATCH net-next] netdevsim: fix nsim_fib6_rt_create() error path Message-ID: <20200115201107.GA1513116@splinter> References: <20200115195741.86879-1-edumazet@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200115195741.86879-1-edumazet@google.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 15, 2020 at 11:57:41AM -0800, Eric Dumazet wrote: > It seems nsim_fib6_rt_create() intent was to return > either a valid pointer or an embedded error code. ... > > Fixes: 48bb9eb47b27 ("netdevsim: fib: Add dummy implementation for FIB offload") > Signed-off-by: Eric Dumazet > Reported-by: syzbot > Cc: Ido Schimmel Reviewed-by: Ido Schimmel Thanks, Eric.