From: Guillaume Nault <gnault@redhat.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] netns: Parse *_PID and *_FD netlink attributes as signed integers
Date: Thu, 16 Jan 2020 12:23:06 +0100 [thread overview]
Message-ID: <20200116112306.GA22775@linux.home> (raw)
In-Reply-To: <4eb09a3c-f402-ad05-3cff-049578ed0935@6wind.com>
On Wed, Jan 15, 2020 at 05:25:42PM +0100, Nicolas Dichtel wrote:
> Le 15/01/2020 à 16:36, Guillaume Nault a écrit :
> > These attributes represent signed values (file descriptors and PIDs).
> > Make that clear in nla_policy.
> After more check, I also find these one:
> $ git grep "NET.*_PID\|NET.*_FD" include/uapi/linux/
> include/uapi/linux/devlink.h: DEVLINK_ATTR_NETNS_FD, /* u32 */
> include/uapi/linux/devlink.h: DEVLINK_ATTR_NETNS_PID, /* u32 */
> include/uapi/linux/gtp.h: GTPA_NET_NS_FD,
> include/uapi/linux/if_link.h: IFLA_NET_NS_PID,
> include/uapi/linux/if_link.h: IFLA_NET_NS_FD,
> include/uapi/linux/net_namespace.h: NETNSA_PID,
> include/uapi/linux/net_namespace.h: NETNSA_FD,
> include/uapi/linux/nl80211.h: NL80211_ATTR_NETNS_FD,
>
Well, this is really going beyond the scope of the original patch set.
But ok, let's drop this series. I'll repost the constification as stand
alone patch and will audit the netns attribute parsing when I'll get
more time.
next prev parent reply other threads:[~2020-01-16 11:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 15:36 [PATCH net-next v2 0/2] netns: simple cleanups Guillaume Nault
2020-01-15 15:36 ` [PATCH net-next v2 1/2] netns: Parse *_PID and *_FD netlink attributes as signed integers Guillaume Nault
2020-01-15 16:25 ` Nicolas Dichtel
2020-01-16 11:23 ` Guillaume Nault [this message]
2020-01-15 15:36 ` [PATCH net-next v2 2/2] netns: constify exported functions Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116112306.GA22775@linux.home \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).