From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E729BC33CB6 for ; Thu, 16 Jan 2020 19:02:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B948F206E6 for ; Thu, 16 Jan 2020 19:02:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579201365; bh=oGGrABFoCE66QEGKz/t3ZELCjP6BGSRD8f8dFyHbJzA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=d1t+HyNyMHYTmJ81CLU0DH+bmrNf2NfLeffXpeVYPAUqY7erW0nXzuJg9gFbe5WfR W3UE2x3CE38TaUSYAeocdzv69evXFodjJh/mWn4o3rPvqXPBBElgNJzA0KBJI1xp/M WR+ZN7gyvm/UutneJIXz5QbawZN7u1NVJGyR1OYk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407269AbgAPTCo (ORCPT ); Thu, 16 Jan 2020 14:02:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:34548 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388757AbgAPRFf (ORCPT ); Thu, 16 Jan 2020 12:05:35 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1EE39207FF; Thu, 16 Jan 2020 17:05:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579194335; bh=oGGrABFoCE66QEGKz/t3ZELCjP6BGSRD8f8dFyHbJzA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FtV9ru17zvXYaT2+yBSPgA9J6FVZubqqhapcYJQ/u+2gYC6NFg5VXsDNfWqM8cg8a SMVKc6xgPi+PDP5Uj6IZFQFI8UmUzJ8kKrG+HuVoaAe1CdnG4ZprbfXVtDKXIKaAuN u+AEt5v8d0jYE5tMU3QB7cwk+PP5LtvdKiQXMPX4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Andrey Ignatov , Daniel Borkmann , Sasha Levin , netdev@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 280/671] bpf: Add missed newline in verifier verbose log Date: Thu, 16 Jan 2020 11:58:38 -0500 Message-Id: <20200116170509.12787-17-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116170509.12787-1-sashal@kernel.org> References: <20200116170509.12787-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Andrey Ignatov [ Upstream commit 1fbd20f8b77b366ea4aeb92ade72daa7f36a7e3b ] check_stack_access() that prints verbose log is used in adjust_ptr_min_max_vals() that prints its own verbose log and now they stick together, e.g.: variable stack access var_off=(0xfffffffffffffff0; 0x4) off=-16 size=1R2 stack pointer arithmetic goes out of range, prohibited for !root Add missing newline so that log is more readable: variable stack access var_off=(0xfffffffffffffff0; 0x4) off=-16 size=1 R2 stack pointer arithmetic goes out of range, prohibited for !root Fixes: f1174f77b50c ("bpf/verifier: rework value tracking") Signed-off-by: Andrey Ignatov Signed-off-by: Daniel Borkmann Signed-off-by: Sasha Levin --- kernel/bpf/verifier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index 9e72b2f8c3dd..0952049b5ff1 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -1253,7 +1253,7 @@ static int check_stack_access(struct bpf_verifier_env *env, char tn_buf[48]; tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off); - verbose(env, "variable stack access var_off=%s off=%d size=%d", + verbose(env, "variable stack access var_off=%s off=%d size=%d\n", tn_buf, off, size); return -EACCES; } -- 2.20.1