From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 438C8C33CB6 for ; Thu, 16 Jan 2020 18:08:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 176992176D for ; Thu, 16 Jan 2020 18:08:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579198088; bh=ik203C7T/WXo7xNpkBr/BT49DUc3f6ZgvZoYxnQ/4Pk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=x8Sz/FhExmSRU+w0fwtZlgLBjLaVf5LDHgZ5c6Esi2qbJfcpa0FbgJW3cZQISIKyq SYG6a/FHZvQdZlFHc2lxS1b03LaZU2inoLdP6dRUoFmXDdsjXpbRD1xp5THsNsaoF/ zhfICEJvNgxVpS+r7LpeysSm+clrS7W5VDBOg1AY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393389AbgAPRix (ORCPT ); Thu, 16 Jan 2020 12:38:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:54806 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393383AbgAPRit (ORCPT ); Thu, 16 Jan 2020 12:38:49 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B5AC524708; Thu, 16 Jan 2020 17:38:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196329; bh=ik203C7T/WXo7xNpkBr/BT49DUc3f6ZgvZoYxnQ/4Pk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zVjPYzfII7Dhtaacu25uIn11nkt0bx0aBV6SnR3tnfkPdm1F+JReXMvq4RqBBj/NY Pn8iW9ssgQk1VFqT7HhF8KjOj+uy9YdHx6ZexfGWTnFrANSWcSM28b/uyq/slFVil2 LVBeE55nCryz6HQ60bZhoco7nftq2dotynJj168Y= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sameeh Jubran , Arthur Kiyanovski , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 130/251] net: ena: fix incorrect test of supported hash function Date: Thu, 16 Jan 2020 12:34:39 -0500 Message-Id: <20200116173641.22137-90-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116173641.22137-1-sashal@kernel.org> References: <20200116173641.22137-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Sameeh Jubran [ Upstream commit d3cfe7ddbc3dfbb9b201615b7fef8fd66d1b5fe8 ] ena_com_set_hash_function() tests if a hash function is supported by the device before setting it. The test returns the opposite result than needed. Reverse the condition to return the correct value. Also use the BIT macro instead of inline shift. Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)") Signed-off-by: Arthur Kiyanovski Signed-off-by: Sameeh Jubran Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/amazon/ena/ena_com.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c index bcd993140f84..2d196d521b83 100644 --- a/drivers/net/ethernet/amazon/ena/ena_com.c +++ b/drivers/net/ethernet/amazon/ena/ena_com.c @@ -1967,7 +1967,7 @@ int ena_com_set_hash_function(struct ena_com_dev *ena_dev) if (unlikely(ret)) return ret; - if (get_resp.u.flow_hash_func.supported_func & (1 << rss->hash_func)) { + if (!(get_resp.u.flow_hash_func.supported_func & BIT(rss->hash_func))) { pr_err("Func hash %d isn't supported by device, abort\n", rss->hash_func); return -EPERM; -- 2.20.1