* [PATCH net-next] enetc: Don't print from enetc_sched_speed_set when link goes down
@ 2020-01-16 17:18 Vladimir Oltean
2020-01-16 20:46 ` Andrew Lunn
2020-01-17 10:49 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Vladimir Oltean @ 2020-01-16 17:18 UTC (permalink / raw)
To: davem; +Cc: netdev, claudiu.manoil, po.liu, Vladimir Oltean
From: Vladimir Oltean <vladimir.oltean@nxp.com>
It is not an error to unplug a cable from the ENETC port even with TSN
offloads, so don't spam the log with link-related messages from the
tc-taprio offload subsystem, a single notification is sufficient:
[10972.351859] fsl_enetc 0000:00:00.0 eno0: Qbv PSPEED set speed link down.
[10972.360241] fsl_enetc 0000:00:00.0 eno0: Link is Down
Fixes: 2e47cb415f0a ("enetc: update TSN Qbv PSPEED set according to adjust link speed")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
drivers/net/ethernet/freescale/enetc/enetc_qos.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/enetc/enetc_qos.c b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
index 00382b7c5bd8..0c6bf3a55a9a 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_qos.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
@@ -36,7 +36,6 @@ void enetc_sched_speed_set(struct net_device *ndev)
case SPEED_10:
default:
pspeed = ENETC_PMR_PSPEED_10M;
- netdev_err(ndev, "Qbv PSPEED set speed link down.\n");
}
priv->speed = speed;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] enetc: Don't print from enetc_sched_speed_set when link goes down
2020-01-16 17:18 [PATCH net-next] enetc: Don't print from enetc_sched_speed_set when link goes down Vladimir Oltean
@ 2020-01-16 20:46 ` Andrew Lunn
2020-01-17 10:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2020-01-16 20:46 UTC (permalink / raw)
To: Vladimir Oltean; +Cc: davem, netdev, claudiu.manoil, po.liu, Vladimir Oltean
On Thu, Jan 16, 2020 at 07:18:28PM +0200, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> It is not an error to unplug a cable from the ENETC port even with TSN
> offloads, so don't spam the log with link-related messages from the
> tc-taprio offload subsystem, a single notification is sufficient:
>
> [10972.351859] fsl_enetc 0000:00:00.0 eno0: Qbv PSPEED set speed link down.
> [10972.360241] fsl_enetc 0000:00:00.0 eno0: Link is Down
>
> Fixes: 2e47cb415f0a ("enetc: update TSN Qbv PSPEED set according to adjust link speed")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] enetc: Don't print from enetc_sched_speed_set when link goes down
2020-01-16 17:18 [PATCH net-next] enetc: Don't print from enetc_sched_speed_set when link goes down Vladimir Oltean
2020-01-16 20:46 ` Andrew Lunn
@ 2020-01-17 10:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-01-17 10:49 UTC (permalink / raw)
To: olteanv; +Cc: netdev, claudiu.manoil, po.liu, vladimir.oltean
From: Vladimir Oltean <olteanv@gmail.com>
Date: Thu, 16 Jan 2020 19:18:28 +0200
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> It is not an error to unplug a cable from the ENETC port even with TSN
> offloads, so don't spam the log with link-related messages from the
> tc-taprio offload subsystem, a single notification is sufficient:
>
> [10972.351859] fsl_enetc 0000:00:00.0 eno0: Qbv PSPEED set speed link down.
> [10972.360241] fsl_enetc 0000:00:00.0 eno0: Link is Down
>
> Fixes: 2e47cb415f0a ("enetc: update TSN Qbv PSPEED set according to adjust link speed")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-17 10:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-16 17:18 [PATCH net-next] enetc: Don't print from enetc_sched_speed_set when link goes down Vladimir Oltean
2020-01-16 20:46 ` Andrew Lunn
2020-01-17 10:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).