From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32D9BC33CB1 for ; Fri, 17 Jan 2020 10:37:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 116B02073A for ; Fri, 17 Jan 2020 10:37:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726832AbgAQKhQ (ORCPT ); Fri, 17 Jan 2020 05:37:16 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:48970 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726085AbgAQKhQ (ORCPT ); Fri, 17 Jan 2020 05:37:16 -0500 Received: from localhost (82-95-191-104.ip.xs4all.nl [82.95.191.104]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 099ED155CB0BA; Fri, 17 Jan 2020 02:37:13 -0800 (PST) Date: Fri, 17 Jan 2020 02:37:12 -0800 (PST) Message-Id: <20200117.023712.1513971272629755906.davem@davemloft.net> To: m.grzeschik@pengutronix.de Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, kernel@pengutronix.de Subject: Re: [PATCH v4] net: phy: dp83867: Set FORCE_LINK_GOOD to default after reset From: David Miller In-Reply-To: <20200116131631.31724-1-m.grzeschik@pengutronix.de> References: <20200116.045753.1672747031363850521.davem@davemloft.net> <20200116131631.31724-1-m.grzeschik@pengutronix.de> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 17 Jan 2020 02:37:15 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Michael Grzeschik Date: Thu, 16 Jan 2020 14:16:31 +0100 > According to the Datasheet this bit should be 0 (Normal operation) in > default. With the FORCE_LINK_GOOD bit set, it is not possible to get a > link. This patch sets FORCE_LINK_GOOD to the default value after > resetting the phy. > > Signed-off-by: Michael Grzeschik Applied and queued up for -stable.