netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: systemport: Fixed queue mapping in internal ring map
Date: Fri, 17 Jan 2020 04:32:19 -0800 (PST)	[thread overview]
Message-ID: <20200117.043219.1348996138082295599.davem@davemloft.net> (raw)
In-Reply-To: <20200116210859.7376-1-f.fainelli@gmail.com>

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Thu, 16 Jan 2020 13:08:58 -0800

> We would not be transmitting using the correct SYSTEMPORT transmit queue
> during ndo_select_queue() which looks up the internal TX ring map
> because while establishing the mapping we would be off by 4, so for
> instance, when we populate switch port mappings we would be doing:
> 
> switch port 0, queue 0 -> ring index #0
> switch port 0, queue 1 -> ring index #1
> ...
> switch port 0, queue 3 -> ring index #3
> switch port 1, queue 0 -> ring index #8 (4 + 4 * 1)
> ...
> 
> instead of using ring index #4. This would cause our ndo_select_queue()
> to use the fallback queue mechanism which would pick up an incorrect
> ring for that switch port. Fix this by using the correct switch queue
> number instead of SYSTEMPORT queue number.
> 
> Fixes: 3ed67ca243b3 ("net: systemport: Simplify queue mapping logic")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Applied, but I had to fix the SHA1-ID of the Fixes tag to be:

    Fixes: 25c440704661 ("net: systemport: Simplify queue mapping logic")

Thanks.

  reply	other threads:[~2020-01-19 11:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-16 21:08 [PATCH net] net: systemport: Fixed queue mapping in internal ring map Florian Fainelli
2020-01-17 12:32 ` David Miller [this message]
2020-01-19 17:48   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200117.043219.1348996138082295599.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).