From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CAEBC33CB1 for ; Fri, 17 Jan 2020 10:40:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 09E222073A for ; Fri, 17 Jan 2020 10:40:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726688AbgAQKj7 (ORCPT ); Fri, 17 Jan 2020 05:39:59 -0500 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:45450 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726196AbgAQKj7 (ORCPT ); Fri, 17 Jan 2020 05:39:59 -0500 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1isP2j-0007ey-Q8; Fri, 17 Jan 2020 11:39:57 +0100 Date: Fri, 17 Jan 2020 11:39:57 +0100 From: Florian Westphal To: Toke =?iso-8859-15?Q?H=F8iland-J=F8rgensen?= Cc: Florian Westphal , netdev@vger.kernel.org Subject: Re: [PATCH net-next] netlink: make getters tolerate NULL nla arg Message-ID: <20200117103957.GV795@breakpoint.cc> References: <20200116145522.28803-1-fw@strlen.de> <87eevzsa2m.fsf@toke.dk> <20200116160435.GT795@breakpoint.cc> <8736cfs73w.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8736cfs73w.fsf@toke.dk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Toke Høiland-Jørgensen wrote: > And that the crashes at least shine a light on > them forcing people to consider whether that is indeed the case? > > (IDK if that's actually the case, I'm asking :)) All I was saying is that if the getters were more tolerant a few crash bugs could have been avoided.