* [PATCH] staging: qlge: fix missing a blank line after declaration
@ 2020-01-19 14:03 Valery Ivanov
2020-01-22 8:44 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Valery Ivanov @ 2020-01-19 14:03 UTC (permalink / raw)
To: manishc, GR-Linux-NIC-Dev; +Cc: gregkh, netdev, devel, linux-kernel
This patch fixes "WARNING: Missing a blank lin after declarations"
Issue found by checkpatch.pl
Signed-off-by: Valery Ivanov <ivalery111@gmail.com>
---
drivers/staging/qlge/qlge_ethtool.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/qlge/qlge_ethtool.c b/drivers/staging/qlge/qlge_ethtool.c
index 56d116d79e56..2872b7120e36 100644
--- a/drivers/staging/qlge/qlge_ethtool.c
+++ b/drivers/staging/qlge/qlge_ethtool.c
@@ -412,6 +412,7 @@ static void ql_get_drvinfo(struct net_device *ndev,
struct ethtool_drvinfo *drvinfo)
{
struct ql_adapter *qdev = netdev_priv(ndev);
+
strlcpy(drvinfo->driver, qlge_driver_name, sizeof(drvinfo->driver));
strlcpy(drvinfo->version, qlge_driver_version,
sizeof(drvinfo->version));
@@ -703,12 +704,14 @@ static int ql_set_pauseparam(struct net_device *netdev,
static u32 ql_get_msglevel(struct net_device *ndev)
{
struct ql_adapter *qdev = netdev_priv(ndev);
+
return qdev->msg_enable;
}
static void ql_set_msglevel(struct net_device *ndev, u32 value)
{
struct ql_adapter *qdev = netdev_priv(ndev);
+
qdev->msg_enable = value;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: qlge: fix missing a blank line after declaration
2020-01-19 14:03 [PATCH] staging: qlge: fix missing a blank line after declaration Valery Ivanov
@ 2020-01-22 8:44 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2020-01-22 8:44 UTC (permalink / raw)
To: Valery Ivanov; +Cc: manishc, GR-Linux-NIC-Dev, devel, linux-kernel, netdev
On Sun, Jan 19, 2020 at 04:03:59PM +0200, Valery Ivanov wrote:
> This patch fixes "WARNING: Missing a blank lin after declarations"
> Issue found by checkpatch.pl
>
> Signed-off-by: Valery Ivanov <ivalery111@gmail.com>
> ---
> drivers/staging/qlge/qlge_ethtool.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/qlge/qlge_ethtool.c b/drivers/staging/qlge/qlge_ethtool.c
> index 56d116d79e56..2872b7120e36 100644
> --- a/drivers/staging/qlge/qlge_ethtool.c
> +++ b/drivers/staging/qlge/qlge_ethtool.c
> @@ -412,6 +412,7 @@ static void ql_get_drvinfo(struct net_device *ndev,
> struct ethtool_drvinfo *drvinfo)
> {
> struct ql_adapter *qdev = netdev_priv(ndev);
> +
> strlcpy(drvinfo->driver, qlge_driver_name, sizeof(drvinfo->driver));
> strlcpy(drvinfo->version, qlge_driver_version,
> sizeof(drvinfo->version));
> @@ -703,12 +704,14 @@ static int ql_set_pauseparam(struct net_device *netdev,
> static u32 ql_get_msglevel(struct net_device *ndev)
> {
> struct ql_adapter *qdev = netdev_priv(ndev);
> +
> return qdev->msg_enable;
> }
>
> static void ql_set_msglevel(struct net_device *ndev, u32 value)
> {
> struct ql_adapter *qdev = netdev_priv(ndev);
> +
> qdev->msg_enable = value;
> }
>
This fix is already in my tree, always be sure to work against
linux-next for new development so you do not duplicate existing work.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-22 8:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-19 14:03 [PATCH] staging: qlge: fix missing a blank line after declaration Valery Ivanov
2020-01-22 8:44 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).