netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	David Miller <davem@davemloft.net>,
	Realtek linux nic maintainers <nic_swsd@realtek.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 0/2] net: phy: add generic ndo_do_ioctl handler phy_do_ioctl
Date: Sun, 19 Jan 2020 21:50:59 +0100	[thread overview]
Message-ID: <20200119205059.GD17720@lunn.ch> (raw)
In-Reply-To: <82737a2f-b6c1-943e-42a2-d42d87212457@gmail.com>

> Speaking for r8169:
> If interface is up and cable detached, then it runtime-suspends
> and goes into PCI D3 (chip and MDIO bus not accessible).
> But ndev is "running" and PHY is attached.

Hi Heiner

And how does it get out of this state? I assume the PHY interrupts
when the link is established. Is phylib handling this interrupt? If
so, when phylib accesses the MDIO bus, the bus needs to be runtime PM
aware. And if the bus is runtime PM aware, the IOCTL handler should
work, when the device is runtime suspended.  If the MAC is handling
this interrupt, and it is the MAC interrupt handler which is run-time
unsuspending, then the ioctl handler is not going to work unless it
also runtime unsuspends.

	Andrew

  reply	other threads:[~2020-01-19 20:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-19 13:31 [PATCH net-next 0/2] net: phy: add generic ndo_do_ioctl handler phy_do_ioctl Heiner Kallweit
2020-01-19 13:31 ` [PATCH net-next 1/2] " Heiner Kallweit
2020-01-19 13:32 ` [PATCH net-next 2/2] r8169: use " Heiner Kallweit
2020-01-19 16:12 ` [PATCH net-next 0/2] net: phy: add " Andrew Lunn
2020-01-19 17:18   ` Heiner Kallweit
2020-01-19 17:51     ` Andrew Lunn
2020-01-19 18:19       ` Heiner Kallweit
2020-01-19 18:50         ` Andrew Lunn
2020-01-19 19:19           ` Heiner Kallweit
2020-01-19 20:50             ` Andrew Lunn [this message]
2020-01-19 22:28               ` Heiner Kallweit
2020-01-20 20:35                 ` Heiner Kallweit
2020-01-20  9:42       ` David Miller
2020-01-20  9:43 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200119205059.GD17720@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).