* Regression in macvlan driver in stable release 4.4.209
@ 2020-01-20 9:17 Hans-Christian Egtvedt (hegtvedt)
2020-01-20 9:57 ` Ido Schimmel
0 siblings, 1 reply; 5+ messages in thread
From: Hans-Christian Egtvedt (hegtvedt) @ 2020-01-20 9:17 UTC (permalink / raw)
To: netdev@vger.kernel.org
Cc: stable@vger.kernel.org, Eric Dumazet, Greg Kroah-Hartman
Hello,
I am seeing a regression in the macvlan kernel driver after Linux stable
release 4.4.209, bisecting identifies commit
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-4.4.y&id=8d28d7e88851b1081b05dc269a27df1c8a903f3e
There seems to be a history behind this, and I do not have the full
overview of the intention behind the change.
What I see on my target, Aarch64 CPU, is that this patch moves the eth
pointer in macvlan_broadcast() function some bytes. This will cause
everything within the ethhdr struct to be wrong AFAICT.
An example:
Original code "eth = eth_hdr(skb)"
eth = ffffffc007a1b002
New code "eth = skb_eth_hdr(skb)"
eth = ffffffc007a1b010
Let me know if I can assist in any way.
--
Best regards,
Hans-Christian Noren Egtvedt
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: Regression in macvlan driver in stable release 4.4.209
2020-01-20 9:17 Regression in macvlan driver in stable release 4.4.209 Hans-Christian Egtvedt (hegtvedt)
@ 2020-01-20 9:57 ` Ido Schimmel
2020-01-20 10:03 ` Hans-Christian Egtvedt (hegtvedt)
2020-01-20 18:35 ` Sasha Levin
0 siblings, 2 replies; 5+ messages in thread
From: Ido Schimmel @ 2020-01-20 9:57 UTC (permalink / raw)
To: Hans-Christian Egtvedt (hegtvedt)
Cc: netdev@vger.kernel.org, stable@vger.kernel.org, Eric Dumazet,
Greg Kroah-Hartman
On Mon, Jan 20, 2020 at 09:17:35AM +0000, Hans-Christian Egtvedt (hegtvedt) wrote:
> Hello,
>
> I am seeing a regression in the macvlan kernel driver after Linux stable
> release 4.4.209, bisecting identifies commit
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-4.4.y&id=8d28d7e88851b1081b05dc269a27df1c8a903f3e
Noticed it too last week (on net-next), but Eric already fixed it:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1712b2fff8c682d145c7889d2290696647d82dab
I assume the patch will find its way to 4.4.y soon now that it is in
mainline.
>
> There seems to be a history behind this, and I do not have the full
> overview of the intention behind the change.
>
> What I see on my target, Aarch64 CPU, is that this patch moves the eth
> pointer in macvlan_broadcast() function some bytes. This will cause
> everything within the ethhdr struct to be wrong AFAICT.
>
> An example:
> Original code "eth = eth_hdr(skb)"
> eth = ffffffc007a1b002
> New code "eth = skb_eth_hdr(skb)"
> eth = ffffffc007a1b010
>
> Let me know if I can assist in any way.
>
> --
> Best regards,
> Hans-Christian Noren Egtvedt
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Regression in macvlan driver in stable release 4.4.209
2020-01-20 9:57 ` Ido Schimmel
@ 2020-01-20 10:03 ` Hans-Christian Egtvedt (hegtvedt)
2020-01-20 18:35 ` Sasha Levin
1 sibling, 0 replies; 5+ messages in thread
From: Hans-Christian Egtvedt (hegtvedt) @ 2020-01-20 10:03 UTC (permalink / raw)
To: Ido Schimmel
Cc: netdev@vger.kernel.org, stable@vger.kernel.org, Eric Dumazet,
Greg Kroah-Hartman
On 20.01.2020 10:57, Ido Schimmel wrote:
> On Mon, Jan 20, 2020 at 09:17:35AM +0000, Hans-Christian Egtvedt (hegtvedt) wrote:
>> Hello,
>>
>> I am seeing a regression in the macvlan kernel driver after Linux stable
>> release 4.4.209, bisecting identifies commit
>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-4.4.y&id=8d28d7e88851b1081b05dc269a27df1c8a903f3e
>
> Noticed it too last week (on net-next), but Eric already fixed it:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1712b2fff8c682d145c7889d2290696647d82dab
>
> I assume the patch will find its way to 4.4.y soon now that it is in
> mainline.
Excellent, thank you for the quick update.
I will know what to look for in upcoming 4.4.y releases.
>> There seems to be a history behind this, and I do not have the full
>> overview of the intention behind the change.
>>
>> What I see on my target, Aarch64 CPU, is that this patch moves the eth
>> pointer in macvlan_broadcast() function some bytes. This will cause
>> everything within the ethhdr struct to be wrong AFAICT.
>>
>> An example:
>> Original code "eth = eth_hdr(skb)"
>> eth = ffffffc007a1b002
>> New code "eth = skb_eth_hdr(skb)"
>> eth = ffffffc007a1b010
>>
>> Let me know if I can assist in any way.--
Best regards,
Hans-Christian Noren Egtvedt
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Regression in macvlan driver in stable release 4.4.209
2020-01-20 9:57 ` Ido Schimmel
2020-01-20 10:03 ` Hans-Christian Egtvedt (hegtvedt)
@ 2020-01-20 18:35 ` Sasha Levin
2020-01-20 18:47 ` David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Sasha Levin @ 2020-01-20 18:35 UTC (permalink / raw)
To: Ido Schimmel
Cc: Hans-Christian Egtvedt (hegtvedt), netdev@vger.kernel.org,
stable@vger.kernel.org, Eric Dumazet, Greg Kroah-Hartman
On Mon, Jan 20, 2020 at 11:57:14AM +0200, Ido Schimmel wrote:
>On Mon, Jan 20, 2020 at 09:17:35AM +0000, Hans-Christian Egtvedt (hegtvedt) wrote:
>> Hello,
>>
>> I am seeing a regression in the macvlan kernel driver after Linux stable
>> release 4.4.209, bisecting identifies commit
>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-4.4.y&id=8d28d7e88851b1081b05dc269a27df1c8a903f3e
>
>Noticed it too last week (on net-next), but Eric already fixed it:
>https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1712b2fff8c682d145c7889d2290696647d82dab
>
>I assume the patch will find its way to 4.4.y soon now that it is in
>mainline.
David, any objection if I grab this patch directly to fix the regression
in the next stable kernel release?
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Regression in macvlan driver in stable release 4.4.209
2020-01-20 18:35 ` Sasha Levin
@ 2020-01-20 18:47 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2020-01-20 18:47 UTC (permalink / raw)
To: sashal; +Cc: idosch, hegtvedt, netdev, stable, edumazet, gregkh
From: Sasha Levin <sashal@kernel.org>
Date: Mon, 20 Jan 2020 13:35:15 -0500
> On Mon, Jan 20, 2020 at 11:57:14AM +0200, Ido Schimmel wrote:
>>On Mon, Jan 20, 2020 at 09:17:35AM +0000, Hans-Christian Egtvedt
>>(hegtvedt) wrote:
>>> Hello,
>>>
>>> I am seeing a regression in the macvlan kernel driver after Linux
>>> stable
>>> release 4.4.209, bisecting identifies commit
>>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-4.4.y&id=8d28d7e88851b1081b05dc269a27df1c8a903f3e
>>
>>Noticed it too last week (on net-next), but Eric already fixed it:
>>https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1712b2fff8c682d145c7889d2290696647d82dab
>>
>>I assume the patch will find its way to 4.4.y soon now that it is in
>>mainline.
>
> David, any objection if I grab this patch directly to fix the
> regression
> in the next stable kernel release?
Sure, no problem.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-20 18:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-20 9:17 Regression in macvlan driver in stable release 4.4.209 Hans-Christian Egtvedt (hegtvedt)
2020-01-20 9:57 ` Ido Schimmel
2020-01-20 10:03 ` Hans-Christian Egtvedt (hegtvedt)
2020-01-20 18:35 ` Sasha Levin
2020-01-20 18:47 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).