Netdev List
 help / color / mirror / Atom feed
From: William Dauchy <w.dauchy@criteo.com>
To: netdev@vger.kernel.org
Cc: Pravin B Shelar <pshelar@nicira.com>,
	William Tu <u9012063@gmail.com>,
	Nicolas Dichtel <nicolas.dichtel@6wind.com>,
	William Dauchy <w.dauchy@criteo.com>
Subject: [PATCH] net, ip_tunnel: fix namespaces move
Date: Tue, 21 Jan 2020 13:36:26 +0100	[thread overview]
Message-ID: <20200121123626.35884-1-w.dauchy@criteo.com> (raw)

in the same manner as commit 690afc165bb3 ("net: ip6_gre: fix moving
ip6gre between namespaces"), fix namespace moving as it was broken since
commit 2e15ea390e6f ("ip_gre: Add support to collect tunnel metadata.").
Indeed, the ip6_gre commit removed the local flag for collect_md
condition, so there is no reason to keep it for ip_gre/ip_tunnel.

this patch will fix both ip_tunnel and ip_gre modules.

Signed-off-by: William Dauchy <w.dauchy@criteo.com>
---
 net/ipv4/ip_tunnel.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c
index 0fe2a5d3e258..74e1d964a615 100644
--- a/net/ipv4/ip_tunnel.c
+++ b/net/ipv4/ip_tunnel.c
@@ -1236,10 +1236,8 @@ int ip_tunnel_init(struct net_device *dev)
 	iph->version		= 4;
 	iph->ihl		= 5;
 
-	if (tunnel->collect_md) {
-		dev->features |= NETIF_F_NETNS_LOCAL;
+	if (tunnel->collect_md)
 		netif_keep_dst(dev);
-	}
 	return 0;
 }
 EXPORT_SYMBOL_GPL(ip_tunnel_init);
-- 
2.24.1


             reply	other threads:[~2020-01-21 12:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-21 12:36 William Dauchy [this message]
2020-01-21 12:56 ` [PATCH] net, ip_tunnel: fix namespaces move Nicolas Dichtel
2020-01-21 13:06   ` William Dauchy
2020-01-21 14:15     ` Nicolas Dichtel
2020-01-21 14:26       ` [PATCH v2] " William Dauchy
2020-01-21 14:28         ` Nicolas Dichtel
2020-01-21 15:06         ` David Miller
2020-01-21 15:30           ` William Dauchy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200121123626.35884-1-w.dauchy@criteo.com \
    --to=w.dauchy@criteo.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=pshelar@nicira.com \
    --cc=u9012063@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox