Netdev List
 help / color / mirror / Atom feed
From: gautamramk@gmail.com
To: netdev@vger.kernel.org
Cc: "Mohit P. Tahiliani" <tahiliani@nitk.edu.in>,
	"Jamal Hadi Salim" <jhs@mojatatu.com>,
	"David S . Miller" <davem@davemloft.net>,
	"Dave Taht" <dave.taht@gmail.com>,
	"Toke Høiland-Jørgensen" <toke@redhat.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Stephen Hemminger" <stephen@networkplumber.org>,
	"Leslie Monis" <lesliemonis@gmail.com>,
	"Gautam Ramakrishnan" <gautamramk@gmail.com>
Subject: [PATCH net-next v4 07/10] net: sched: pie: fix commenting
Date: Tue, 21 Jan 2020 19:42:46 +0530	[thread overview]
Message-ID: <20200121141250.26989-8-gautamramk@gmail.com> (raw)
In-Reply-To: <20200121141250.26989-1-gautamramk@gmail.com>

From: "Mohit P. Tahiliani" <tahiliani@nitk.edu.in>

Fix punctuation and logical mistakes in the comments.
The logical mistake was that "dequeue_rate" is no longer
the default way to calculate queuing delay and is not
needed. The default way to calculate queue delay was
changed in commit cec2975f2b70 ("net: sched: pie:
enable timestamp based delay calculation").

Signed-off-by: Mohit P. Tahiliani <tahiliani@nitk.edu.in>
Signed-off-by: Leslie Monis <lesliemonis@gmail.com>
Signed-off-by: Gautam Ramakrishnan <gautamramk@gmail.com>
---
 net/sched/sch_pie.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c
index 7197bcaa14ba..c0a4df01c0a0 100644
--- a/net/sched/sch_pie.c
+++ b/net/sched/sch_pie.c
@@ -248,10 +248,10 @@ static void pie_process_dequeue(struct Qdisc *sch, struct sk_buff *skb)
 		q->vars.dq_count = 0;
 	}
 
-	/* Calculate the average drain rate from this value.  If queue length
-	 * has receded to a small value viz., <= QUEUE_THRESHOLD bytes,reset
+	/* Calculate the average drain rate from this value. If queue length
+	 * has receded to a small value viz., <= QUEUE_THRESHOLD bytes, reset
 	 * the dq_count to -1 as we don't have enough packets to calculate the
-	 * drain rate anymore The following if block is entered only when we
+	 * drain rate anymore. The following if block is entered only when we
 	 * have a substantial queue built up (QUEUE_THRESHOLD bytes or more)
 	 * and we calculate the drain rate for the threshold here.  dq_count is
 	 * in bytes, time difference in psched_time, hence rate is in
@@ -329,8 +329,8 @@ static void calculate_probability(struct Qdisc *sch)
 		qdelay_old = q->vars.qdelay_old;
 	}
 
-	/* If qdelay is zero and qlen is not, it means qlen is very small, less
-	 * than dequeue_rate, so we do not update probabilty in this round
+	/* If qdelay is zero and qlen is not, it means qlen is very small,
+	 * so we do not update probabilty in this round.
 	 */
 	if (qdelay == 0 && qlen != 0)
 		update_prob = false;
-- 
2.17.1


  parent reply	other threads:[~2020-01-21 14:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-21 14:12 [PATCH net-next v4 00/10] net: sched: add Flow Queue PIE packet scheduler gautamramk
2020-01-21 14:12 ` [PATCH net-next v4 01/10] net: sched: pie: move common code to pie.h gautamramk
2020-01-21 14:12 ` [PATCH net-next v4 02/10] pie: use U64_MAX to denote (2^64 - 1) gautamramk
2020-01-21 14:12 ` [PATCH net-next v4 03/10] pie: rearrange macros in order of length gautamramk
2020-01-21 14:12 ` [PATCH net-next v4 04/10] pie: use u8 instead of bool in pie_vars gautamramk
2020-01-21 14:12 ` [PATCH net-next v4 05/10] pie: rearrange structure members and their initializations gautamramk
2020-01-21 14:35   ` David Miller
2020-01-21 15:44     ` Gautam Ramakrishnan
2020-01-21 16:02       ` Toke Høiland-Jørgensen
2020-01-21 16:44         ` Leslie Monis
2020-01-21 16:09       ` David Miller
2020-01-21 16:52         ` Leslie Monis
2020-01-21 14:12 ` [PATCH net-next v4 06/10] pie: improve comments and commenting style gautamramk
2020-01-21 14:12 ` gautamramk [this message]
2020-01-21 14:12 ` [PATCH net-next v4 08/10] net: sched: pie: fix alignment in struct instances gautamramk
2020-01-21 14:12 ` [PATCH net-next v4 09/10] net: sched: pie: export symbols to be reused by FQ-PIE gautamramk
2020-01-21 14:12 ` [PATCH net-next v4 10/10] net: sched: add Flow Queue PIE packet scheduler gautamramk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200121141250.26989-8-gautamramk@gmail.com \
    --to=gautamramk@gmail.com \
    --cc=dave.taht@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=kuba@kernel.org \
    --cc=lesliemonis@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=tahiliani@nitk.edu.in \
    --cc=toke@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox