From: David Miller <davem@davemloft.net>
To: pabeni@redhat.com
Cc: netdev@vger.kernel.org, willemdebruijn.kernel@gmail.com
Subject: Re: [PATCH net] Revert "udp: do rmem bulk free even if the rx sk queue is empty"
Date: Wed, 22 Jan 2020 21:10:01 +0100 (CET) [thread overview]
Message-ID: <20200122.211001.959451019501750401.davem@davemloft.net> (raw)
In-Reply-To: <ec4444596ced8bd90da812538198d97703186626.1579615523.git.pabeni@redhat.com>
From: Paolo Abeni <pabeni@redhat.com>
Date: Tue, 21 Jan 2020 16:50:49 +0100
> This reverts commit 0d4a6608f68c7532dcbfec2ea1150c9761767d03.
>
> Williem reported that after commit 0d4a6608f68c ("udp: do rmem bulk
> free even if the rx sk queue is empty") the memory allocated by
> an almost idle system with many UDP sockets can grow a lot.
>
> For stable kernel keep the solution as simple as possible and revert
> the offending commit.
>
> Reported-by: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> Diagnosed-by: Eric Dumazet <eric.dumazet@gmail.com>
> Fixes: 0d4a6608f68c ("udp: do rmem bulk free even if the rx sk queue is empty")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2020-01-22 20:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 15:50 [PATCH net] Revert "udp: do rmem bulk free even if the rx sk queue is empty" Paolo Abeni
2020-01-21 18:26 ` Willem de Bruijn
2020-01-22 10:02 ` Sergei Shtylyov
2020-01-22 20:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122.211001.959451019501750401.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).