From: Andrew Lunn <andrew@lunn.ch>
To: Luigi Rizzo <lrizzo@google.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Michal Kubecek <mkubecek@suse.cz>
Subject: Re: [PATCH] net-core: remove unnecessary ETHTOOL_GCHANNELS initialization
Date: Thu, 23 Jan 2020 00:47:53 +0100 [thread overview]
Message-ID: <20200122234753.GA13647@lunn.ch> (raw)
In-Reply-To: <20200122223326.187954-1-lrizzo@google.com>
On Wed, Jan 22, 2020 at 02:33:26PM -0800, Luigi Rizzo wrote:
> struct ethtool_channels does not need .cmd to be set when calling the
> driver's ethtool methods. Just zero-initialize it.
>
> Tested: run ethtool -l and ethtool -L
Hi Luigi
This seems pretty risky. You are assuming ethtool is the only user of
this API. What is actually wrong with putting a sane cmd value, rather
than the undefined value 0.
Andrew
next prev parent reply other threads:[~2020-01-22 23:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 22:33 [PATCH] net-core: remove unnecessary ETHTOOL_GCHANNELS initialization Luigi Rizzo
2020-01-22 23:47 ` Andrew Lunn [this message]
2020-01-23 0:18 ` Luigi Rizzo
2020-01-23 8:28 ` Michal Kubecek
2020-01-23 8:40 ` Michal Kubecek
2020-01-23 17:47 ` Luigi Rizzo
2020-01-23 20:01 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122234753.GA13647@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=lrizzo@google.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox